Mailing-List: contact dev-help@storm.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@storm.apache.org
From: vesense <git@git.apache.org>
To: dev@storm.apache.org
Reply-To: dev@storm.apache.org
References: <git-pr-1665-storm@git.apache.org>
In-Reply-To: <git-pr-1665-storm@git.apache.org>
Subject: [GitHub] storm pull request #1665: STORM-2074: fix storm-kafka-monitor NPE bug
Content-Type: text/plain
Message-Id: <20160901025933.71865DFD7B@git1-us-west.apache.org>
Date: Thu,  1 Sep 2016 02:59:33 +0000 (UTC)
archived-at: Thu, 01 Sep 2016 02:59:45 -0000

Github user vesense commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1665#discussion_r77107687
  
    --- Diff: external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/KafkaOffsetLagUtil.java ---
    @@ -373,16 +377,20 @@ private static Options buildOptions () {
             curatorFramework.start();
             String partitionPrefix = "partition_";
             String zkPath = oldKafkaSpoutOffsetQuery.getZkPath();
    -        if (!zkPath.endsWith("/")) {
    -            zkPath += "/";
    +         if (zkPath.endsWith("/")) {
    --- End diff --
    
    I think it is better to check the variable before use it.  and the zkPath must not ends with `/`.
    the `printUsageAndExit` method needs argument  `Options` which is not available in `getOldConsumerOffsetsFromZk`. so I use `exit` directly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---