storm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vesense <>
Subject [GitHub] storm pull request #1665: STORM-2074: fix storm-kafka-monitor NPE bug
Date Thu, 01 Sep 2016 02:59:33 GMT
Github user vesense commented on a diff in the pull request:
    --- Diff: external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/
    @@ -373,16 +377,20 @@ private static Options buildOptions () {
             String partitionPrefix = "partition_";
             String zkPath = oldKafkaSpoutOffsetQuery.getZkPath();
    -        if (!zkPath.endsWith("/")) {
    -            zkPath += "/";
    +         if (zkPath.endsWith("/")) {
    --- End diff --
    I think it is better to check the variable before use it.  and the zkPath must not ends
with `/`.
    the `printUsageAndExit` method needs argument  `Options` which is not available in `getOldConsumerOffsetsFromZk`.
so I use `exit` directly.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message