Return-Path: 
 <issues-return-2409-apmail-stdcxx-issues-archive=stdcxx.apache.org@stdcxx.apache.org>
Delivered-To: apmail-stdcxx-issues-archive@locus.apache.org
Received: (qmail 7467 invoked from network); 5 Sep 2008 19:53:13 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 5 Sep 2008 19:53:13 -0000
Received: (qmail 59129 invoked by uid 500); 5 Sep 2008 19:53:11 -0000
Delivered-To: apmail-stdcxx-issues-archive@stdcxx.apache.org
Received: (qmail 59107 invoked by uid 500); 5 Sep 2008 19:53:11 -0000
Mailing-List: contact issues-help@stdcxx.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@stdcxx.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@stdcxx.apache.org>
List-Post: <mailto:issues@stdcxx.apache.org>
List-Id: <issues.stdcxx.apache.org>
Reply-To: dev@stdcxx.apache.org
Delivered-To: mailing list issues@stdcxx.apache.org
Received: (qmail 59096 invoked by uid 99); 5 Sep 2008 19:53:11 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Sep 2008 12:53:11 -0700
X-ASF-Spam-Status: No, hits=-1998.5 required=10.0
	tests=ALL_TRUSTED,WEIRD_PORT
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Sep 2008 19:52:13 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 46F45234C1D0
	for <issues@stdcxx.apache.org>; Fri,  5 Sep 2008 12:52:44 -0700 (PDT)
Message-ID: <957086906.1220644364275.JavaMail.jira@brutus>
Date: Fri, 5 Sep 2008 12:52:44 -0700 (PDT)
From: "Martin Sebor (JIRA)" <jira@apache.org>
To: issues@stdcxx.apache.org
Subject: [jira] Issue Comment Edited: (STDCXX-1009)
 std::string::{assign|append|insert|replace} ([iterator, iterator,]
 size_type, value_type) ambiguous
In-Reply-To: <2139182584.1220627804351.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/STDCXX-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628711#action_12628711 ] 

sebor edited comment on STDCXX-1009 at 9/5/08 12:50 PM:
---------------------------------------------------------------

Similar errors with gcc 4.3:
{noformat}
$ make t
gcc -c -I/amd/devco/sebor/stdcxx-4.2.x/include/ansi -D_RWSTDDEBUG   -pthread -I/amd/devco/sebor/stdcxx-4.2.x/include -I/build/sebor/stdcxx-4.2.x-gcc-4.3.0-15D/include -I/amd/devco/sebor/stdcxx-4.2.x/tests/include  -pedantic -nostdinc++ -g   -W -Wall -Wcast-qual -Winline -Wshadow -Wwrite-strings -Wno-long-long -Wcast-align   t.cpp
/amd/devco/sebor/stdcxx-4.2.x/include/string: In member function 'std::basic_string<_CharT, _Traits, _Allocator>& std::basic_string<_CharT, _Traits, _Allocator>::replace(__rw::__rw_debug_iter<std::basic_string<_CharT, _Traits, _Allocator>, typename _Allocator::pointer, typename _Allocator::pointer>, __rw::__rw_debug_iter<std::basic_string<_CharT, _Traits, _Allocator>, typename _Allocator::pointer, typename _Allocator::pointer>, _InputIter, _InputIter) [with _InputIter = int, _CharT = char, _Traits = std::char_traits<char>, _Allocator = std::allocator<char>]':
/amd/devco/sebor/stdcxx-4.2.x/include/string:190:   instantiated from 'std::basic_string<_CharT, _Traits, _Allocator>::basic_string(_InputIter, _InputIter, const _Allocator&) [with _InputIter = int, _CharT = char, _Traits = std::char_traits<char>, _Allocator = std::allocator<char>]'
t.cpp:6:   instantiated from here
/amd/devco/sebor/stdcxx-4.2.x/include/string:616: error: call of overloaded 'replace(__rw::__rw_debug_iter<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, char*, char*>&, __rw::__rw_debug_iter<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, char*, char*>&, int&, int&, int)' is ambiguous
/amd/devco/sebor/stdcxx-4.2.x/include/string.cc:494: note: candidates are: std::basic_string<_CharT, _Traits, _Allocator>& std::basic_string<_CharT, _Traits, _Allocator>::replace(__rw::__rw_debug_iter<std::basic_string<_CharT, _Traits, _Allocator>, typename _Allocator::pointer, typename _Allocator::pointer>, __rw::__rw_debug_iter<std::basic_string<_CharT, _Traits, _Allocator>, typename _Allocator::pointer, typename _Allocator::pointer>, _InputIter, _InputIter, void*) [with _InputIter = int, _CharT = char, _Traits = std::char_traits<char>, _Allocator = std::allocator<char>]
/amd/devco/sebor/stdcxx-4.2.x/include/string:606: note:                 std::basic_string<_CharT, _Traits, _Allocator>& std::basic_string<_CharT, _Traits, _Allocator>::replace(__rw::__rw_debug_iter<std::basic_string<_CharT, _Traits, _Allocator>, typename _Allocator::pointer, typename _Allocator::pointer>, __rw::__rw_debug_iter<std::basic_string<_CharT, _Traits, _Allocator>, typename _Allocator::pointer, typename _Allocator::pointer>, typename _Allocator::size_type, typename _Traits::char_type, int) [with _CharT = char, _Traits = std::char_traits<char>, _Allocator = std::allocator<char>]
...
{noformat}

Here's a simplified test case:

{noformat}
#include <string>

int main ()
{
    std::string s (4, int ('5'));
    s.assign (4, int ('5'));
    s.append (4, int ('5'));
    s.insert (s.begin (), 4, int ('5'));
    s.replace (s.begin (), s.end (), 4, int ('5'));
}
{noformat}

      was (Author: sebor):
    Similar errors with gcc 4.3:
{noformat}
$ make t
gcc -c -I/amd/devco/sebor/stdcxx-4.2.x/include/ansi -D_RWSTDDEBUG   -pthread -I/amd/devco/sebor/stdcxx-4.2.x/include -I/build/sebor/stdcxx-4.2.x-gcc-4.3.0-15D/include -I/amd/devco/sebor/stdcxx-4.2.x/tests/include  -pedantic -nostdinc++ -g   -W -Wall -Wcast-qual -Winline -Wshadow -Wwrite-strings -Wno-long-long -Wcast-align   t.cpp
/amd/devco/sebor/stdcxx-4.2.x/include/string: In member function 'std::basic_string<_CharT, _Traits, _Allocator>& std::basic_string<_CharT, _Traits, _Allocator>::replace(__rw::__rw_debug_iter<std::basic_string<_CharT, _Traits, _Allocator>, typename _Allocator::pointer, typename _Allocator::pointer>, __rw::__rw_debug_iter<std::basic_string<_CharT, _Traits, _Allocator>, typename _Allocator::pointer, typename _Allocator::pointer>, _InputIter, _InputIter) [with _InputIter = int, _CharT = char, _Traits = std::char_traits<char>, _Allocator = std::allocator<char>]':
/amd/devco/sebor/stdcxx-4.2.x/include/string:190:   instantiated from 'std::basic_string<_CharT, _Traits, _Allocator>::basic_string(_InputIter, _InputIter, const _Allocator&) [with _InputIter = int, _CharT = char, _Traits = std::char_traits<char>, _Allocator = std::allocator<char>]'
t.cpp:6:   instantiated from here
/amd/devco/sebor/stdcxx-4.2.x/include/string:616: error: call of overloaded 'replace(__rw::__rw_debug_iter<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, char*, char*>&, __rw::__rw_debug_iter<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, char*, char*>&, int&, int&, int)' is ambiguous
/amd/devco/sebor/stdcxx-4.2.x/include/string.cc:494: note: candidates are: std::basic_string<_CharT, _Traits, _Allocator>& std::basic_string<_CharT, _Traits, _Allocator>::replace(__rw::__rw_debug_iter<std::basic_string<_CharT, _Traits, _Allocator>, typename _Allocator::pointer, typename _Allocator::pointer>, __rw::__rw_debug_iter<std::basic_string<_CharT, _Traits, _Allocator>, typename _Allocator::pointer, typename _Allocator::pointer>, _InputIter, _InputIter, void*) [with _InputIter = int, _CharT = char, _Traits = std::char_traits<char>, _Allocator = std::allocator<char>]
/amd/devco/sebor/stdcxx-4.2.x/include/string:606: note:                 std::basic_string<_CharT, _Traits, _Allocator>& std::basic_string<_CharT, _Traits, _Allocator>::replace(__rw::__rw_debug_iter<std::basic_string<_CharT, _Traits, _Allocator>, typename _Allocator::pointer, typename _Allocator::pointer>, __rw::__rw_debug_iter<std::basic_string<_CharT, _Traits, _Allocator>, typename _Allocator::pointer, typename _Allocator::pointer>, typename _Allocator::size_type, typename _Traits::char_type, int) [with _CharT = char, _Traits = std::char_traits<char>, _Allocator = std::allocator<char>]
...
{noformat}
  
> std::string::{assign|append|insert|replace} ([iterator, iterator,] size_type, value_type) ambiguous
> ---------------------------------------------------------------------------------------------------
>
>                 Key: STDCXX-1009
>                 URL: https://issues.apache.org/jira/browse/STDCXX-1009
>             Project: C++ Standard Library
>          Issue Type: Improvement
>          Components: 21. Strings
>    Affects Versions: 4.1.2, 4.1.3, 4.1.4, 4.2.0, 4.2.1
>         Environment: All
>            Reporter: Farid Zaripov
>            Assignee: Farid Zaripov
>            Priority: Minor
>             Fix For: 4.3.0
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The following test case fails to compile:
> {code:title=test.cpp}
> #include <string>
> int main ()
> {
>     char c = 5;
>     std::string s (4, '0' + c);
>     s.assign (4, '0' + c);
>     s.append (4, '0' + c);
>     s.insert (s.begin (), 4, '0' + c);
>     s.replace (s.begin (), s.end (), 4, '0' + c);
>     return 0;
> }
> {code}
> {noformat}
> test.cpp
> D:\_Libs\stdcxx-4.2.2\include\string(370) : error C2666: 'std::basic_string<_CharT,_Traits,_Allocator>::assign' : 2 overloads have similar conversions
>         with
>         [
>             _CharT=char,
>             _Traits=std::char_traits<char>,
>             _Allocator=std::allocator<char>
>         ]
>         D:\_Libs\stdcxx-4.2.2\include\string(381): could be 'std::basic_string<_CharT,_Traits,_Allocator> &std::basic_string<_CharT,_Traits,_Allocator>::assign(std::basic_string<_CharT,_Traits,_Allocator>::size_type,std::basic_string<_CharT,_Traits,_Allocator>::value_type,int)'
>         with
>         [
>             _CharT=char,
>             _Traits=std::char_traits<char>,
>             _Allocator=std::allocator<char>
>         ]
>         D:\_Libs\stdcxx-4.2.2\include\string(374): or       'std::basic_string<_CharT,_Traits,_Allocator> &std::basic_string<_CharT,_Traits,_Allocator>::assign<_InputIter>(_InputIter,_InputIter,void *)'
>         with
>         [
>             _CharT=char,
>             _Traits=std::char_traits<char>,
>             _Allocator=std::allocator<char>,
>             _InputIter=int
>         ]
>         while trying to match the argument list '(int, int, int)'
>         test.cpp(7) : see reference to function template instantiation 'std::basic_string<_CharT,_Traits,_Allocator> &std::basic_string<_CharT,_Traits,_Allocator>::assign<int>(_InputIter,_InputIter)' being compiled
>         with
>         [
>             _CharT=char,
>             _Traits=std::char_traits<char>,
>             _Allocator=std::allocator<char>,
>             _InputIter=int
>         ]
> D:\_Libs\stdcxx-4.2.2\include\string(320) : error C2666: 'std::basic_string<_CharT,_Traits,_Allocator>::append' : 2 overloads have similar conversions
>         with
>         [
>             _CharT=char,
>             _Traits=std::char_traits<char>,
>             _Allocator=std::allocator<char>
>         ]
>         D:\_Libs\stdcxx-4.2.2\include\string(330): could be 'std::basic_string<_CharT,_Traits,_Allocator> &std::basic_string<_CharT,_Traits,_Allocator>::append(std::basic_string<_CharT,_Traits,_Allocator>::size_type,std::basic_string<_CharT,_Traits,_Allocator>::value_type,int)'
>         with
>         [
>             _CharT=char,
>             _Traits=std::char_traits<char>,
>             _Allocator=std::allocator<char>
>         ]
>         D:\_Libs\stdcxx-4.2.2\include\string(324): or       'std::basic_string<_CharT,_Traits,_Allocator> &std::basic_string<_CharT,_Traits,_Allocator>::append<_InputIter>(_InputIter,_InputIter,void *)'
>         with
>         [
>             _CharT=char,
>             _Traits=std::char_traits<char>,
>             _Allocator=std::allocator<char>,
>             _InputIter=int
>         ]
>         while trying to match the argument list '(int, int, int)'
>         test.cpp(8) : see reference to function template instantiation 'std::basic_string<_CharT,_Traits,_Allocator> &std::basic_string<_CharT,_Traits,_Allocator>::append<int>(_InputIter,_InputIter)' being compiled
>         with
>         [
>             _CharT=char,
>             _Traits=std::char_traits<char>,
>             _Allocator=std::allocator<char>,
>             _InputIter=int
>         ]
> D:\_Libs\stdcxx-4.2.2\include\string(422) : error C2666: 'std::basic_string<_CharT,_Traits,_Allocator>::insert' : 2 overloads have similar conversions
>         with
>         [
>             _CharT=char,
>             _Traits=std::char_traits<char>,
>             _Allocator=std::allocator<char>
>         ]
>         D:\_Libs\stdcxx-4.2.2\include\string(432): could be 'void std::basic_string<_CharT,_Traits,_Allocator>::insert(std::basic_string<_CharT,_Traits,_Allocator>::iterator,std::basic_string<_CharT,_Traits,_Allocator>::size_type,std::basic_string<_CharT,_Traits,_Allocator>::value_type,int)'
>         with
>         [
>             _CharT=char,
>             _Traits=std::char_traits<char>,
>             _Allocator=std::allocator<char>
>         ]
>         D:\_Libs\stdcxx-4.2.2\include\string(426): or       'void std::basic_string<_CharT,_Traits,_Allocator>::insert<_InputIter>(std::basic_string<_CharT,_Traits,_Allocator>::iterator,_InputIter,_InputIter,void *)'
>         with
>         [
>             _CharT=char,
>             _Traits=std::char_traits<char>,
>             _Allocator=std::allocator<char>,
>             _InputIter=int
>         ]
>         while trying to match the argument list '(std::basic_string<_CharT,_Traits,_Allocator>::iterator, int, int, int)'
>         with
>         [
>             _CharT=char,
>             _Traits=std::char_traits<char>,
>             _Allocator=std::allocator<char>
>         ]
>         test.cpp(9) : see reference to function template instantiation 'void std::basic_string<_CharT,_Traits,_Allocator>::insert<int>(std::basic_string<_CharT,_Traits,_Allocator>::iterator,_InputIter,_InputIter)' being compiled
>         with
>         [
>             _CharT=char,
>             _Traits=std::char_traits<char>,
>             _Allocator=std::allocator<char>,
>             _InputIter=int
>         ]
> D:\_Libs\stdcxx-4.2.2\include\string(616) : error C2666: 'std::basic_string<_CharT,_Traits,_Allocator>::replace' : 2 overloads have similar conversions
>         with
>         [
>             _CharT=char,
>             _Traits=std::char_traits<char>,
>             _Allocator=std::allocator<char>
>         ]
>         D:\_Libs\stdcxx-4.2.2\include\string(605): could be 'std::basic_string<_CharT,_Traits,_Allocator> &std::basic_string<_CharT,_Traits,_Allocator>::replace(std::basic_string<_CharT,_Traits,_Allocator>::iterator,std::basic_string<_CharT,_Traits,_Allocator>::iterator,std::basic_string<_CharT,_Traits,_Allocator>::size_type,std::basic_string<_CharT,_Traits,_Allocator>::value_type,int)'
>         with
>         [
>             _CharT=char,
>             _Traits=std::char_traits<char>,
>             _Allocator=std::allocator<char>
>         ]
>         D:\_Libs\stdcxx-4.2.2\include\string.cc(493): or       'std::basic_string<_CharT,_Traits,_Allocator> &std::basic_string<_CharT,_Traits,_Allocator>::replace<_InputIter>(std::basic_string<_CharT,_Traits,_Allocator>::iterator,std::basic_string<_CharT,_Traits,_Allocator>::iterator,_InputIter,_InputIter,void *)'
>         with
>         [
>             _CharT=char,
>             _Traits=std::char_traits<char>,
>             _Allocator=std::allocator<char>,
>             _InputIter=int
>         ]
>         while trying to match the argument list '(std::basic_string<_CharT,_Traits,_Allocator>::iterator, std::basic_string<_CharT,_Traits,_Allocator>::iterator, int, int, int)'
>         with
>         [
>             _CharT=char,
>             _Traits=std::char_traits<char>,
>             _Allocator=std::allocator<char>
>         ]
>         and
>         [
>             _CharT=char,
>             _Traits=std::char_traits<char>,
>             _Allocator=std::allocator<char>
>         ]
>         test.cpp(10) : see reference to function template instantiation 'std::basic_string<_CharT,_Traits,_Allocator> &std::basic_string<_CharT,_Traits,_Allocator>::replace<int>(std::basic_string<_CharT,_Traits,_Allocator>::ite
> rator,std::basic_string<_CharT,_Traits,_Allocator>::iterator,_InputIter,_InputIter)' being compiled
>         with
>         [
>             _CharT=char,
>             _Traits=std::char_traits<char>,
>             _Allocator=std::allocator<char>,
>             _InputIter=int
>         ]
> {noformat}
>   The proposed patch:
> {code:title=string.diff}
> Index: include/string
> ===================================================================
> --- include/string	(revision 691313)
> +++ include/string	(working copy)
> @@ -327,9 +327,10 @@
>                          __first, __last), *this;
>      }
>  
> -    basic_string& append (size_type __n, value_type __c, int) {
> +    template <class _IntType>
> +    basic_string& append (_IntType __n, _IntType __c, int) {
>          // unnamed arg is used for overload resolution
> -        return append (__n, __c);
> +        return append (size_type (__n), value_type (__c));
>      }
>  
>  #else   // if defined (_RWSTD_NO_MEMBER_TEMPLATES)
> @@ -378,9 +379,11 @@
>                          _C_make_iter (_C_data + size ()), __first, __last);
>      }
>  
> -    basic_string& assign (size_type __n, value_type __c, int) {
> +    template <class _IntType>
> +    basic_string& assign (_IntType __n, _IntType __c, int) {
>          // unnamed arg is used for overload resolution
> -        return replace (size_type (), size (), __n, __c);
> +        return replace (size_type (), size (),
> +                        size_type (__n), value_type (__c));
>      }
>  
>  #else   // if defined (_RWSTD_NO_MEMBER_TEMPLATES)
> @@ -429,9 +432,11 @@
>          replace (__p, __p, __first, __last);
>      }
>  
> -    void insert (iterator __p, size_type __n, value_type __c, int) {
> +    template <class _IntType>
> +    void insert (iterator __p, _IntType __n, _IntType __c, int) {
>          // unnamed arg is used for overload resolution
> -        replace (_C_off (__p), size_type (), __n, __c);
> +        replace (_C_off (__p), size_type (),
> +                 size_type (__n), value_type (__c));
>      }
>  
>      void insert (iterator __p,
> @@ -601,10 +606,12 @@
>  
>  #  endif   // _RWSTD_NO_STRING_OUTLINED_MEMBER_TEMPLATES
>  
> +    template <class _IntType>
>      basic_string&
>      replace (iterator __first, iterator __last,
> -             size_type __n, value_type __c, int) {
> -        return replace (_C_off (__first), _C_off (__first, __last), __n, __c);
> +             _IntType __n, _IntType __c, int) {
> +        return replace (_C_off (__first), _C_off (__first, __last),
> +                        size_type (__n), value_type (__c));
>      }
>  
>      // 21.3.5.6, p21
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.