Return-Path: Delivered-To: apmail-stdcxx-issues-archive@locus.apache.org Received: (qmail 8282 invoked from network); 5 May 2008 16:53:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 5 May 2008 16:53:18 -0000 Received: (qmail 82179 invoked by uid 500); 5 May 2008 16:53:20 -0000 Delivered-To: apmail-stdcxx-issues-archive@stdcxx.apache.org Received: (qmail 82157 invoked by uid 500); 5 May 2008 16:53:20 -0000 Mailing-List: contact issues-help@stdcxx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@stdcxx.apache.org Delivered-To: mailing list issues@stdcxx.apache.org Received: (qmail 82146 invoked by uid 99); 5 May 2008 16:53:20 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 May 2008 09:53:20 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 May 2008 16:52:41 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 8210E234C100 for ; Mon, 5 May 2008 09:52:55 -0700 (PDT) Message-ID: <1914850144.1210006375518.JavaMail.jira@brutus> Date: Mon, 5 May 2008 09:52:55 -0700 (PDT) From: "Travis Vitek (JIRA)" To: issues@stdcxx.apache.org Subject: [jira] Assigned: (STDCXX-907) messages::do_get() inefficiency requires unnecessary locking In-Reply-To: <1515241012.1209776335634.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/STDCXX-907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Travis Vitek reassigned STDCXX-907: ----------------------------------- Assignee: Travis Vitek > messages::do_get() inefficiency requires unnecessary locking > ------------------------------------------------------------------- > > Key: STDCXX-907 > URL: https://issues.apache.org/jira/browse/STDCXX-907 > Project: C++ Standard Library > Issue Type: Bug > Components: 22. Localization > Affects Versions: 4.2.1 > Reporter: Travis Vitek > Assignee: Travis Vitek > Priority: Minor > Fix For: 4.3 > > Attachments: stdcxx-907.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > The {{_STD::messages::do_get()}} method might actually call {{\_\_rw_manage_cat_data()}} up to three times to access the cache. Since each access involves a mutex lock, there are going to be some wasted cycles. It would be nice to reduce this to one access. Perhaps the {{_RW::\_\_rw_get_message()}} function could be changed to fill in a pointer to the {{_STD::locale}} that is kept in the cache and the {{_RW::\_\_rw_get_locale()}} function could be removed. > For backward binary compatibility we would need to keep the existing functions around, but we could add an overload and then deprecate the old ones using the {{_RWSTD_VER}} macro. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.