stdcxx-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Travis Vitek (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (STDCXX-761) [HP aCC 6.16] Out of bound access in new.cpp
Date Thu, 03 Apr 2008 21:25:24 GMT

    [ https://issues.apache.org/jira/browse/STDCXX-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585290#action_12585290
] 

vitek edited comment on STDCXX-761 at 4/3/08 2:24 PM:
-------------------------------------------------------------

It looks like someone is being tricky. They are assuming that every member in {{rwt_free_store}}
is contiguous [i.e. no padding], and they are actually comparing each of {{new_calls_}}, {{delete_calls_}},
{{blocks_}}, {{bytes_}}, {{max_blocks_}}, {{max_bytes_}} and {{max_block_size_}} with that
one loop. If you decide to fix this, you'll probably end up writing eight loops of two iterations
each.

Also, I'd prefer that the 2 isn't hardcoded and that you use something like {{sizeof (array)
/ sizeof (*array)}}, or a size macro instead.

      was (Author: vitek):
    It looks like someone is being tricky. They are assuming that every member in {{rwt_free_store}}
is contiguous [i.e. no padding], and they are actually comparing each of {{new_calls_}}, {{delete_calls_}},
{{blocks_}}, {{bytes_}}, {{max_blocks_}}, {{max_bytes_}} and {{max_block_size_}} with that
one loop. If you decide to fix this, you'll end up probably end up writing eight loops of
two iterations each.

Also, I'd prefer that the 2 isn't hardcoded and that you use something like {{sizeof (array)
/ sizeof (*array)}}, or a size macro instead.
  
> [HP aCC 6.16] Out of bound access in new.cpp
> --------------------------------------------
>
>                 Key: STDCXX-761
>                 URL: https://issues.apache.org/jira/browse/STDCXX-761
>             Project: C++ Standard Library
>          Issue Type: Sub-task
>          Components: Test Driver
>    Affects Versions: 4.2.0
>         Environment: $ uname -sr && aCC -V
> HP-UX B.11.31
> aCC: HP C/aC++ B3910B A.06.16 [Nov 26 2007]
>            Reporter: Scott (Yu) Zhong
>            Assignee: Eric Lemings
>             Fix For: 4.2.1
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> When compiled with HP aCC 6.16 +w +O, the test driver source file [new.cpp|http://svn.apache.org/repos/asf/stdcxx/trunk/tests/src/new.cpp]
produces the warnings below:
> {noformat}
> aCC -c     -I$(TOPDIR)/include -I$(BUILDDIR)/include -I$(TOPDIR)/tests/include -AA  +O2
 +DD64 +w \
>     +W392 +W655 +W684 +W818 +W819 +W849 +W2193 +W2236 +W2261 +W2340 +W2401 +W2487 +W4227
\
>     +W4229 +W4231 +W4235 +W4237 +W4249 +W4255 +W4272 +W4284 +W4285 +W4286 +W4296 +W4297
+W3348 \
>     $(TOPDIR)/tests/src/new.cpp
> "$(TOPDIR)/tests/src/new.cpp", line 629, procedure rwt_checkpoint: warning #20206-D:
Out of bound access (In expression "(unsigned long long*)(&diff)->new_calls_+i", (&diff)->new_calls_
(type: unsigned long long [2]) has byte range [0 .. 15], writing byte range [0 .. 127].)
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message