stdcxx-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Sebor (JIRA)" <j...@apache.org>
Subject [jira] Commented: (STDCXX-548) add an internal header for __rw::__rw_get_stdio_fmat()
Date Tue, 05 Feb 2008 23:05:10 GMT

    [ https://issues.apache.org/jira/browse/STDCXX-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565940#action_12565940
] 

Martin Sebor commented on STDCXX-548:
-------------------------------------

Looks great, thanks for handling this one!

> add an internal header for __rw::__rw_get_stdio_fmat()
> ------------------------------------------------------
>
>                 Key: STDCXX-548
>                 URL: https://issues.apache.org/jira/browse/STDCXX-548
>             Project: C++ Standard Library
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 4.1.2, 4.1.3, 4.1.4
>         Environment: All.
>            Reporter: Martin Sebor
>            Assignee: Farid Zaripov
>            Priority: Minor
>             Fix For: 4.2.1
>
>         Attachments: stdcxx-548.patch
>
>   Original Estimate: 2h
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> The __rw::__rw_get_stdio_fmat() function (and perhaps some others) defined in src/punct.cpp
and declared as well as used in both num_get.cpp and num_put.cpp. Changing the function signature
involves changing three places instead of two, which is error-prone. See http://svn.apache.org/viewvc?rev=574738&view=rev
and http://svn.apache.org/viewvc?rev=574422&view=rev for an example where this caused
breakage.
> The function (and any other such examples) should be declared in a header to prevent
such incidents.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message