Mailing-List: contact dev-help@stdcxx.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@stdcxx.apache.org
Received-SPF: pass (nike.apache.org: domain of msebor@gmail.com designates
 209.85.214.182 as permitted sender)
Message-ID: <50801A02.4080608@gmail.com>
Date: Thu, 18 Oct 2012 09:02:26 -0600
From: Martin Sebor <msebor@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:11.0) Gecko/20120329 Thunderbird/11.0.1
MIME-Version: 1.0
To: dev@stdcxx.apache.org
CC: Liviu Nicoara <nikkoara@hates.ms>
Subject: Re: [PATCH] STDCXX-1073
References: <50756924.6070802@hates.ms> <507985CD.1050804@hates.ms>
 <507D8D9B.9000307@hates.ms>
In-Reply-To: <507D8D9B.9000307@hates.ms>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 10/16/2012 10:38 AM, Liviu Nicoara wrote:
> I have enhanced the collation test, 22.locale.collate.cpp with a bunch
> of cases that deal with embedded strings, inside the input strings as
> well as at the edges. More defects became apparent, and they have been
> fixed.
>
> I have re-worked the src/collate.cpp patch and I am attaching it here.
> All collation tests (old and new) pass. If there are no objections, I
> will check it in later in the week.

There are tabs in the patch (we need spaces). They also make
the patch harder to review than it otherwise would be. I would
also suggest keeping the MSVC < 8.0 block and cleaning things
up separately. That will also make the patch easier to review.
(I'm so swamped that this matters to me.)

I haven't looked at the test patch yet. If you could clean up
the tab issue and reduce the amount of unnecessary whitespace
changes I promise to review it this weekend.

Martin

>
> Thanks,
> Liviu
>
> On 10/13/12 11:16, Liviu Nicoara wrote:
>> The initial patch does not pass the following test case. Have re-worked
>> the patch and attached it to the incident, and I am also attaching it
>> here. It passes all collate tests.
>
>
>