stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Liviu Nicoara <nikko...@hates.ms>
Subject Re: [PATCH] STDCXX-1073
Date Thu, 18 Oct 2012 22:28:36 GMT
On 10/18/12 11:02, Martin Sebor wrote:
> On 10/16/2012 10:38 AM, Liviu Nicoara wrote:
>> I have enhanced the collation test, 22.locale.collate.cpp with a bunch
>> of cases that deal with embedded strings, inside the input strings as
>> well as at the edges. More defects became apparent, and they have been
>> fixed.
>>
>> I have re-worked the src/collate.cpp patch and I am attaching it here.
>> All collation tests (old and new) pass. If there are no objections, I
>> will check it in later in the week.
>
> There are tabs in the patch (we need spaces). They also make
> the patch harder to review than it otherwise would be. I would
> also suggest keeping the MSVC < 8.0 block and cleaning things
> up separately. That will also make the patch easier to review.
> (I'm so swamped that this matters to me.)

I looked at both (latest) patches and they do not have tabs in them. They were sent in my
last post on the 16th, the one you replied to. The diff without -w is quite a bit verbose
because I moved a whole block in both collate.cpp functions, inside an if, so there are whitespace
differences. svn diff -w gave me a quite decent view of the changes without having to looks
at the actual patched source file.

I am re-attaching the patches, this time created without -w so they would be a bit verbose.
No tabs this time either.

>
> I haven't looked at the test patch yet. If you could clean up
> the tab issue and reduce the amount of unnecessary whitespace
> changes I promise to review it this weekend.

The test enhancements are pretty plain, just a bunch of added stuff.
  
Thanks,
Liviu


Mime
View raw message