stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <mse...@gmail.com>
Subject Re: svn commit: r1389337 - /stdcxx/branches/4.2.x/tests/support/atomic_xchg.cpp
Date Wed, 26 Sep 2012 03:20:29 GMT
On 09/24/2012 06:38 AM, lnicoara@apache.org wrote:
> Author: lnicoara
> Date: Mon Sep 24 12:38:17 2012
> New Revision: 1389337
>
> URL: http://svn.apache.org/viewvc?rev=1389337&view=rev
> Log:
> 2012-09-24  Liviu Nicoara  <nikkoara@hates.ms>
>
>      * tests/support/atomic_xchg.cpp: (run_test) moved counter volatile
>        qualification to match STDCXX conventions (see r1388733)

The stdcxx ChangeLog format follows the GNU Coding Standard:
   http://www.gnu.org/prep/standards/html_node/Change-Logs.html

I.e., this entry should look like this:

     * tests/support/atomic_xchg.cpp (run_test): Move counter
       volatile qualification to match STDCXX convention (see
       r1388733).

(The colon follows the parenthesized function name. The text
should also end with a period.)

The svn propedit command lets you change a comment for an
already committed change.

Martin

>
>
>
> Modified:
>      stdcxx/branches/4.2.x/tests/support/atomic_xchg.cpp
>
> Modified: stdcxx/branches/4.2.x/tests/support/atomic_xchg.cpp
> URL: http://svn.apache.org/viewvc/stdcxx/branches/4.2.x/tests/support/atomic_xchg.cpp?rev=1389337&r1=1389336&r2=1389337&view=diff
> ==============================================================================
> --- stdcxx/branches/4.2.x/tests/support/atomic_xchg.cpp (original)
> +++ stdcxx/branches/4.2.x/tests/support/atomic_xchg.cpp Mon Sep 24 12:38:17 2012
> @@ -297,7 +297,7 @@ void run_test (intT, thr_args_base::tag_
>       // compute the expected result, "skipping" zeros by incrementing
>       // expect twice when it overflows and wraps around to 0 (zero is
>       // used as the lock variable in thread_routine() above)
> -    intT volatile expect = intT (1);
> +    volatile intT expect = intT (1);
>
>       const unsigned long nincr = (Args::nthreads_ * Args::nincr_) / 2U;
>
>
>


Mime
View raw message