Mailing-List: contact dev-help@stdcxx.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@stdcxx.apache.org
Received-SPF: pass (athena.apache.org: domain of msebor@gmail.com designates
 209.85.198.233 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:content-type:content-transfer-encoding;
        b=dMFXiSC/dwwhXsz34sDPFpMAtYxkbn38sasMig9HyVirkOoxsq1VKF4FKRY0O4t0TI
         V2p7w/5bo0xw8yk1/vfSJEYOyfJOEAh42bH0qsqtp/OrqXTAbbBsgiBy+nz5GCvZq2za
         +dNEp+00erqyLT4JdfEhYdZfrzsSgpaPqei4I=
Message-ID: <48FFF0E4.60905@gmail.com>
Date: Wed, 22 Oct 2008 21:35:00 -0600
From: Martin Sebor <msebor@gmail.com>
User-Agent: Thunderbird 2.0.0.16 (X11/20080723)
MIME-Version: 1.0
To: dev@stdcxx.apache.org
Subject: Re: [PATCH] STDCXX-401 test suite should honor TMPDIR
References: 
 <CFFDD219128FD94FB4F92B99F52D0A4901708EDF@exchmail01.Blue.Roguewave.Com>
 <48FD613C.1000608@gmail.com>
 <CFFDD219128FD94FB4F92B99F52D0A4901708EE0@exchmail01.Blue.Roguewave.Com>
In-Reply-To: 
 <CFFDD219128FD94FB4F92B99F52D0A4901708EE0@exchmail01.Blue.Roguewave.Com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Scott Zhong wrote:
> I think I'll use this email scottyuzhong@gmail.com

Okay, please check the new change log message:
   http://svn.apache.org/viewvc?view=rev&revision=706515

In the future, please include your email info in the log message.

> 
>> -----Original Message-----
>> From: Martin Sebor [mailto:msebor@gmail.com]
>> Sent: Monday, October 20, 2008 10:58 PM
>> To: dev@stdcxx.apache.org
>> Subject: Re: [PATCH] STDCXX-401 test suite should honor TMPDIR
>>
>> Scott Zhong wrote:
>>> Changelog:
>>>
>>> * tests/src/file.cpp (rw_tmpnam): use TMPDIR variable from
> environment
>>> if defined.
>> Okay, thanks. Patch committed here:
>>    http://svn.apache.org/viewvc?rev=706515&view=rev
>>
>> FYI: I used your Rogue Wave email address to complete your change
>> comment. If that's not what you want listed in the ChangeLog please
>> provide an alternate address.
>>
>> Martin
>>
>>> here is the patch:
>>>
>>> Index: tests/src/file.cpp
>>> ===================================================================
>>> --- tests/src/file.cpp  (revision 702657)
>>> +++ tests/src/file.cpp  (working copy)
>>> @@ -208,8 +208,13 @@
>>>  #ifndef _RWSTD_NO_MKSTEMP
>>>  #  define TMP_TEMPLATE      "tmpfile-XXXXXX"
>>>
>>> +    const char *tmpdir = getenv ("TMPDIR");
>>> +    if (tmpdir == NULL) {
>>> +        tmpdir = P_tmpdir;
>>> +    }
>>> +
>>>      if (!buf) {
>>> -        static char fname_buf [sizeof (P_tmpdir) + sizeof
>>> (TMP_TEMPLATE)];
>>> +        static char fname_buf [PATH_MAX];
>>>
>>>          buf = fname_buf;
>>>          *buf = '\0';
>>> @@ -217,13 +222,13 @@
>>>
>>>      if ('\0' == *buf) {
>>>          // copy the template to the buffer; make sure there is
> exactly
>>> -        // one path separator character between P_tmpdir and the
> file
>>> +        // one path separator character between tmpdir and the file
>>>          // name template (it doesn't really matter how many there
> are
>>>          // as long as it's at least one, but one looks better than
> two
>>>          // in diagnostic messages)
>>> -        size_t len = sizeof (P_tmpdir) - 1;
>>> +        size_t len = strlen (tmpdir) - 1;
>>>
>>> -        memcpy (buf, P_tmpdir, len);
>>> +        memcpy (buf, tmpdir, len);
>>>          if (_RWSTD_PATH_SEP != buf [len - 1])
>>>              buf [len++] = _RWSTD_PATH_SEP;
>>>
>>> @@ -251,7 +256,7 @@
>>>  #  ifdef _WIN32
>>>
>>>      // create a temporary file name
>>> -    char* fname = tempnam (P_tmpdir, ".rwtest-tmp");
>>> +    char* fname = tempnam (tmpdir, ".rwtest-tmp");
>>>
>>>      if (fname) {
>>>
>>> @@ -272,7 +277,7 @@
>>>      else {
>>>          fprintf (stderr, "%s:%d: tempnam(\"%s\", \"%s\") failed:
> %s\n",
>>>                   __FILE__, __LINE__,
>>> -                 P_tmpdir, ".rwtest-tmp", strerror (errno));
>>> +                 tmpdir, ".rwtest-tmp", strerror (errno));
>>>      }
>>>
>>>  #  else
>>>
> 
>