Mailing-List: contact dev-help@stdcxx.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@stdcxx.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Message-ID: <485FBE17.8070901@roguewave.com>
Date: Mon, 23 Jun 2008 09:15:35 -0600
From: Martin Sebor <sebor@roguewave.com>
Organization: Rogue Wave Software, Inc.
User-Agent: Thunderbird 2.0.0.12 (X11/20080226)
MIME-Version: 1.0
To: dev@stdcxx.apache.org
Subject: Re: Inconsistent indentation in preprocessing directives
References: 
 <CFFDD219128FD94FB4F92B99F52D0A49010A3852@exchmail01.Blue.Roguewave.Com>
In-Reply-To: 
 <CFFDD219128FD94FB4F92B99F52D0A49010A3852@exchmail01.Blue.Roguewave.Com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Eric Lemings wrote:
>  
> I was just looking at the indentation in the
> $TOPDIR/include/rw/_static_assert.h header.  Why are the defines within
> the `#ifndef _RWSTD_NO_STATIC_ASSERT' indented but the directives
> outside this #if/#else/#endif block are not?  Should they all be
> indented uniformly or not indented at all?

I agree it's inconsistent but I'm not sure there is much to
be gained from indenting the body of the top level blocks.
The purpose of the indentation is to aid readability and
Since virtually every header is always enclosed in a pair
of #ifdefs, indenting its contents wouldn't do anything to
help in this regard.

Martin

> 
> I realize this is not conventional but if we want to indent
> preprocessing directives, this file should look like this:
> 
> 	#ifndef _RWSTD_RW_STATIC_ASSERT_H_INCLUDED
> 	#  define _RWSTD_RW_STATIC_ASSERT_H_INCLUDED
> 
> 	#  include <rw/_defs.h>
> 
> 	...
> 
> 	#  ifndef _RWSTD_NO_STATIC_ASSERT
> 	#    define _RWSTD_STATIC_ASSERT(Cond)
> 	...
> 	#  else
> 	#    define _RWSTD_STATIC_ASSERT(Cond,Mesg) static_assert(Cond,
> Mesg)
> 	#  endif   // _RWSTD_NO_STATIC_ASSERT
> 
> 	#endif   // _RWSTD_RW_STATIC_ASSERT_H_INCLUDED
> 
> Otherwise, we shouldn't indent at all.
> 
> Thanks,
> Brad.