stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Travis Vitek" <Travis.Vi...@roguewave.com>
Subject RE: [jira] Commented: (STDCXX-901) 26.class.gslice test fails
Date Wed, 04 Jun 2008 08:53:18 GMT

Sorry for top posting, but this webmail app won't prefix existing lines. Argh!

I've pulled the patch from stdcxx-901 as I've come up with a much more obvious and clean solution.
I'll post an updated patch in the morning.

Travis

-----Original Message-----
From: Travis Vitek [mailto:Travis.Vitek@roguewave.com]
Sent: Tue 6/3/2008 6:54 PM
To: dev@stdcxx.apache.org
Subject: RE: [jira] Commented: (STDCXX-901) 26.class.gslice test fails
 
 

Okay, I have a fix. It isn't as pretty as I'd like it to be, but it is
forward and backward binary compatible. I'm attaching the patch to the
issue, which you can find by clicking the link below. Please review when
you have a chance.

 
http://issues.apache.org/jira/secure/attachment/12383346/stdcxx-901.patc
h

Note that I left some commented references to a new inline method
gslice::is_empty(). If I submit the fix to 4.2.x I plan to remove these
lines. When the fix goes to 4.3.x I'd like to use the clean solution
which allows me to eliminate the friendship and direct member access. I
also realize that the test is currently incomplete. I will obviously be
working to finish up the test before submitting the patch.

Travis


Mime
  • Unnamed multipart/mixed (inline, None, 0 bytes)
View raw message