From dev-return-7700-apmail-stdcxx-dev-archive=stdcxx.apache.org@stdcxx.apache.org Fri May 30 18:15:14 2008 Return-Path: Delivered-To: apmail-stdcxx-dev-archive@www.apache.org Received: (qmail 38462 invoked from network); 30 May 2008 18:15:14 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 30 May 2008 18:15:14 -0000 Received: (qmail 86389 invoked by uid 500); 30 May 2008 18:15:16 -0000 Delivered-To: apmail-stdcxx-dev-archive@stdcxx.apache.org Received: (qmail 86377 invoked by uid 500); 30 May 2008 18:15:16 -0000 Mailing-List: contact dev-help@stdcxx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@stdcxx.apache.org Delivered-To: mailing list dev@stdcxx.apache.org Received: (qmail 86366 invoked by uid 99); 30 May 2008 18:15:16 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 May 2008 11:15:16 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [208.30.140.160] (HELO moroha.roguewave.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 May 2008 18:14:28 +0000 Received: from exchmail01.Blue.Roguewave.Com (exchmail01.blue.roguewave.com [10.22.129.22]) by moroha.roguewave.com (8.13.6/8.13.6) with ESMTP id m4UIEhMB026601 for ; Fri, 30 May 2008 18:14:43 GMT Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: RE: svn commit: r659253 - in /stdcxx/branches/4.2.x: examples/manual/ src/ tests/algorithms/ tests/containers/ tests/localization/ tests/numerics/ tests/regress/ tests/src/ tests/strings/ util/ X-MimeOLE: Produced By Microsoft Exchange V6.5 Date: Fri, 30 May 2008 12:14:50 -0600 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: svn commit: r659253 - in /stdcxx/branches/4.2.x: examples/manual/ src/ tests/algorithms/ tests/containers/ tests/localization/ tests/numerics/ tests/regress/ tests/src/ tests/strings/ util/ Thread-Index: Aci8++Evrx4C7baFRXSx8RkKCOL/UgFgv9iA References: <20080522205446.F2AE02388A1F@eris.apache.org> <483700C4.703@roguewave.com> From: "Eric Lemings" To: X-Virus-Checked: Checked by ClamAV on apache.org =20 > -----Original Message----- > From: Martin Sebor [mailto:sebor@roguewave.com]=20 > Sent: Friday, May 23, 2008 11:37 AM > To: dev@stdcxx.apache.org > Subject: Re: svn commit: r659253 - in /stdcxx/branches/4.2.x:=20 > examples/manual/ src/ tests/algorithms/ tests/containers/=20 > tests/localization/ tests/numerics/ tests/regress/ tests/src/=20 > tests/strings/ util/ >=20 ... >=20 > FYI: The cast above changes the semantics of the expression > by slicing the high 32-bits of which (when it's 64 bits wide) > before shifting the result right, potentially causing it to > lose its high order bits. I don't think the code is really > unsafe since which is 32 bits wide in ILP32 but a more robust > fix (should the type of which change to 64 bits in the future) > would be to cast the result of the shift expression. Oh so instead of casting just which, cast the result of the whole expression? I'll add that to my TODO list. Brad.