stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Lemings" <Eric.Lemi...@roguewave.com>
Subject RE: svn commit: r659253 - in /stdcxx/branches/4.2.x: examples/manual/ src/ tests/algorithms/ tests/containers/ tests/localization/ tests/numerics/ tests/regress/ tests/src/ tests/strings/ util/
Date Fri, 30 May 2008 20:36:24 GMT
 

> -----Original Message-----
> From: Travis Vitek [mailto:Travis.Vitek@roguewave.com] 
> Sent: Friday, May 23, 2008 2:24 PM
> To: dev@stdcxx.apache.org
> Subject: RE: svn commit: r659253 - in /stdcxx/branches/4.2.x: 
> examples/manual/ src/ tests/algorithms/ tests/containers/ 
> tests/localization/ tests/numerics/ tests/regress/ tests/src/ 
> tests/strings/ util/
> 
>  
...
> 
> Looks like there is some duplication of summaries here. Both of these
> are about the same changes. The log should probably be modified.
> 
> Also, I noticed that the formatting you're using isn't consistent with
> what we normally use for changelog entries. As an example, I see that
> you are indenting some lines. In the above snip you've 
> indented the line
> that begins with tests/algorithms/25.generate.cpp in the second block.
> There should be an asterisk there. You are doing the same thing with
> function names in other places.
> 
> Also, if the description of the resolution is the same as the entry
> above, you should probably just write 'Ditto.' and leave it at that.

Fixed.  See svn propchange: r659253 - svn:log.

> 
> 
> >Modified: stdcxx/branches/4.2.x/tests/algorithms/25.fill.cpp
> >URL: 
> >http://svn.apache.org/viewvc/stdcxx/branches/4.2.x/tests/algori
> >thms/25.fill.cpp?rev=659253&r1=659252&r2=659253&view=diff
> >===============================================================
> >===============
> >--- stdcxx/branches/4.2.x/tests/algorithms/25.fill.cpp (original)
> >+++ stdcxx/branches/4.2.x/tests/algorithms/25.fill.cpp Thu May 
> >22 13:54:39 2008
> >@@ -146,7 +146,7 @@
> >         const OutputIterator begin =
> >             make_iter (buf, buf, buf_end, dummy_iter);
> > 
> >-        const Size n (i, 0 /* dummy */);
> >+        const Size n (int (i), 0 /* dummy */);
> >         const T    value;
> > 
> >         // the number of invocations of the assignment operator
> >
> 
> Wouldn't the correct way to fix this be to add a member typedef to the
> Size class template and then use it? That way the code would 
> be correct
> if Size is actually Size<short> or whatever. _TYPENAME
> Size::IntegralType(i) is pretty verbose, but it is correct.

That it would.  I didn't actually look past the constructor call to
the Size class template.  Fixing it now.

Brad.

Mime
View raw message