Return-Path: Delivered-To: apmail-stdcxx-dev-archive@www.apache.org Received: (qmail 69470 invoked from network); 30 Apr 2008 20:12:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 30 Apr 2008 20:12:37 -0000 Received: (qmail 66427 invoked by uid 500); 30 Apr 2008 20:12:39 -0000 Delivered-To: apmail-stdcxx-dev-archive@stdcxx.apache.org Received: (qmail 66404 invoked by uid 500); 30 Apr 2008 20:12:39 -0000 Mailing-List: contact dev-help@stdcxx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@stdcxx.apache.org Delivered-To: mailing list dev@stdcxx.apache.org Received: (qmail 66393 invoked by uid 99); 30 Apr 2008 20:12:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Apr 2008 13:12:38 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [208.30.140.160] (HELO moroha.roguewave.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Apr 2008 20:11:52 +0000 Received: from nebula.bco.roguewave.com ([10.70.3.27]) by moroha.roguewave.com (8.13.6/8.13.6) with ESMTP id m3UKC5DN018547 for ; Wed, 30 Apr 2008 20:12:05 GMT Message-ID: <4818D295.4000607@roguewave.com> Date: Wed, 30 Apr 2008 14:12:05 -0600 From: Martin Sebor Organization: Rogue Wave Software, Inc. User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: dev@stdcxx.apache.org Subject: Re: [jira] Commented: (STDCXX-866) add 22.locale.ctype.widen.cpp References: <564350175.1209572398599.JavaMail.jira@brutus> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Eric Lemings wrote: > > Should I go ahead and delete the recently added test, close this issue, > and create a new issue to split the widen/narrow and tolower/toupper > tests (if there isn't one already)? If the new test only duplicates what 22.locale.narrow.cpp does I see no reason to keep it (so yes, I'd delete it and close the subtask as Invalid or Won't Fix). If you want to open an issue to split up the existing tests feel free to do so but unless you take the time to do it yourself I wouldn't hold my breath that it gets done unless there's a compelling reason to mess with it (e.g., failures that are hard to analyze because of the current structure). Martin > > Brad. > >> -----Original Message----- >> From: Martin Sebor (JIRA) [mailto:jira@apache.org] >> Sent: Wednesday, April 30, 2008 10:20 AM >> To: issues@stdcxx.apache.org >> Subject: [jira] Commented: (STDCXX-866) add 22.locale.ctype.widen.cpp >> >> >> [ >> https://issues.apache.org/jira/browse/STDCXX-866?page=com.atla >> ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focus >> edCommentId=12593367#action_12593367 ] >> >> Martin Sebor commented on STDCXX-866: >> ------------------------------------- >> >> Splitting up the >> [22.locale.ctype.narrow.cpp|http://svn.apache.org/repos/asf/st >> dcxx/trunk/tests/localization/22.locale.ctype.narrow.cpp] >> test sounds great but see this >> [discussion|http://stdcxx.markmail.org/message/lagbm23t6j5gv7c >> t] for some of the background on the structure of the test >> and why it exercises both functions. >> >> As for including the new tests in 4.2.2 (if it happens), I >> see no problem with it. >> >>> add 22.locale.ctype.widen.cpp >>> ----------------------------- >>> >>> Key: STDCXX-866 >>> URL: >> https://issues.apache.org/jira/browse/STDCXX-866 >>> Project: C++ Standard Library >>> Issue Type: Sub-task >>> Components: Tests >>> Affects Versions: 4.1.2, 4.1.3, 4.1.4, 4.2.0 >>> Reporter: Martin Sebor >>> Assignee: Eric Lemings >>> Fix For: 4.2.1 >>> >>> Attachments: 22.locale.ctype.widen.cpp, 22_ctype_widen.cpp >>> >>> Original Estimate: 2h >>> Time Spent: 1h >>> Remaining Estimate: 1h >>> >>> The test 22_ctype_widen.cpp needs to be migrated from the >> Rogue Wave source code repository into Subversion under the name >> [localization/22.locale.ctype.widen.cpp|http://svn.apache.org/ >> repos/asf/stdcxx/trunk/tests/localization/22.locale.ctype.widen.cpp]. >> >> -- >> This message is automatically generated by JIRA. >> - >> You can reply to this email to add a comment to the issue online. >> >>