stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: svn commit: r645445 - /stdcxx/trunk/util/output.cpp
Date Mon, 07 Apr 2008 14:44:58 GMT
vitek@apache.org wrote:
> Author: vitek
> Date: Mon Apr  7 03:30:03 2008
> New Revision: 645445
> 
> URL: http://svn.apache.org/viewvc?rev=645445&view=rev
> Log:
> 
> 2008-04-07  Travis Vitek  <vitek@roguewave.com>
> 
> 	* util/output.cpp (parse_output): Open file in binary mode
> 	to avoid problems with line end translation in rbinit() and
> 	rbgetc() on windows.
> 	(check_test): Remove line end sequence from scan because file
> 	opened in binary mode will not have translated line ends.
> 	(check_example): Open example output file in binary mode to be
> 	consistent with other file that is used for diff.
> 
> Modified:
>     stdcxx/trunk/util/output.cpp
> 
> Modified: stdcxx/trunk/util/output.cpp
> URL: http://svn.apache.org/viewvc/stdcxx/trunk/util/output.cpp?rev=645445&r1=645444&r2=645445&view=diff
> ==============================================================================
> --- stdcxx/trunk/util/output.cpp (original)
> +++ stdcxx/trunk/util/output.cpp Mon Apr  7 03:30:03 2008
> @@ -318,7 +318,7 @@
>          return;
>      }
>  
> -    if (!rbscanf (&buf, "| INACTIVE |\n# +")) {
> +    if (!rbscanf (&buf, "| INACTIVE |")) {

Maybe we could use rw_fnmatch() here to future-proof the pattern
against formatting changes? (I realize exec doesn't have access
to the test driver yet but that could/should change.)

Martin


Mime
View raw message