Mailing-List: contact dev-help@stdcxx.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@stdcxx.apache.org
Received-SPF: pass (nike.apache.org: local policy)
Message-ID: <47A36FD5.50704@roguewave.com>
Date: Fri, 01 Feb 2008 12:15:33 -0700
From: Martin Sebor <sebor@roguewave.com>
Organization: Rogue Wave Software, Inc.
User-Agent: Thunderbird 2.0.0.9 (X11/20071115)
MIME-Version: 1.0
To: dev@stdcxx.apache.org
Subject: Re: [PATCH] STDCXX-423
References: 
 <CFFDD219128FD94FB4F92B99F52D0A499A2B0D@exchmail01.Blue.Roguewave.Com>
In-Reply-To: 
 <CFFDD219128FD94FB4F92B99F52D0A499A2B0D@exchmail01.Blue.Roguewave.Com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Scott,

I think we might need some help understanding how this change
is intended to solve the problem with the padding bits. FYI,
unsigned char is the only type that may not have padding bits
so I'm not sure I see how it could help.

Martin

Scott Zhong wrote:
> Index: etc/config/src/LIMITS.cpp
> ===================================================================
> --- etc/config/src/LIMITS.cpp   (revision 616446)
> +++ etc/config/src/LIMITS.cpp   (working copy)
> @@ -216,8 +216,10 @@
>  {
>      unsigned bits = 0;
>  
> -    for (unsigned char c = '\01'; c; c <<= 1, ++bits);
> +    unsigned char pc = '\02'; // arbitrary value not equal to '\01'
>  
> +    for (unsigned char c = '\01'; c; c <<= 1) { if(c == pc) break; pc =
> c; bits++; }
> +
>      printf ("#define _RWSTD_CHAR_BIT    %2u\n", bits);
>  
>      return bits;