stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Farid Zaripov" <Farid_Zari...@epam.com>
Subject RE: [PATCH] STDCXX-563
Date Wed, 20 Feb 2008 17:45:27 GMT
> -----Original Message-----
> From: Scott Zhong [mailto:Scott.Zhong@roguewave.com] 
> Sent: Tuesday, February 12, 2008 10:24 PM
> To: dev@stdcxx.apache.org
> Subject: [PATCH] STDCXX-563
> 
> Split _mutex.h into
> 
> _mutex-aix.h
> _mutex-deccxx.h
> _mutex.h
> _mutex-i386gcc.h
> _mutex-ia64-x86-64.h
> _mutex-parisc.h
> _mutex-sgi.h
> _mutex-sparc.h
> 
> http://www.fileden.com/files/2008/1/30/1729926/patch.stdcxx-563.tar
> 

  I've reviewed this patch and it's looks good for me.

  The only thing I would like to do is move _InterlockedXXX()
declarations
from _mutex.h to _mutex-i386gcc.h and _mutex-ia64-x86-64.h and use
__rw_atomic_preincrement() in __rw_get_static_mutex() instead of
using _InterlockedIncrement() on WIN32 and usual increment on the
other platforms. But this changes can be applied later in the separated
patch.

Farid.

Mime
View raw message