stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: svn commit: r627618 - /stdcxx/trunk/etc/config/GNUmakefile.cfg
Date Tue, 19 Feb 2008 23:54:15 GMT
Hi Farid,

This change seems to have broken the config test dependency detection
logic and caused the EDG eccp build regression described in STDCXX-733.
I assigned the issue to you but just in case you miss it among all the
other traffic on issues@s.a.o... Can you please take a look into it
whenever you have chance?

     http://issues.apache.org/jira/browse/STDCXX-733

Incidentally, out of curiosity, what is this change supposed to do?

Thanks
Martin

faridz@apache.org wrote:
> Author: faridz
> Date: Wed Feb 13 16:09:02 2008
> New Revision: 627618
> 
> URL: http://svn.apache.org/viewvc?rev=627618&view=rev
> Log:
> 2008-02-14  Farid Zaripov  <farid_zaripov@epam.com>
> 
> 	* etc/config/GNUmakefile.cfg: Check for the LDOPTS dependences
> 	and setup LOPT variable when building the executable target.
> 
> Modified:
>     stdcxx/trunk/etc/config/GNUmakefile.cfg
> 
> Modified: stdcxx/trunk/etc/config/GNUmakefile.cfg
> URL: http://svn.apache.org/viewvc/stdcxx/trunk/etc/config/GNUmakefile.cfg?rev=627618&r1=627617&r2=627618&view=diff
> ==============================================================================
> --- stdcxx/trunk/etc/config/GNUmakefile.cfg (original)
> +++ stdcxx/trunk/etc/config/GNUmakefile.cfg Wed Feb 13 16:09:02 2008
> @@ -363,13 +363,17 @@
>                       -e "s/_RWSTD_NO_//g" -e "s/_RWSTD_//g"` ;         \
>            for sym in $$dep ; do                                        \
>                fname=$$sym ;                                            \
> -              [ ! -r $(SRCDIR)/$$fname.cpp ] && fname="NO_$$fname" ;   \
> +              src=$(SRCDIR)/$$fname.cpp;                               \
> +              [ ! -r $$src ] && fname="NO_$$fname" ;                   \
>                grep "_RWSTD_NO_$$sym$$" config.h >/dev/null ;           \
>                if [ $$? -ne 0 ] ; then                                  \
> -                  grep "[^a-zA-Z0-9_]*main *(" $(SRCDIR)/$$fname.cpp   \
> -                       >/dev/null 2>&1 ;                               \
> +                  grep "[^a-zA-Z0-9_]*main *(" $$src >/dev/null 2>&1 ; \
>                    if [ $$? -eq 0 ] ; then                              \
> -                      targets="$$fname.o $$fname run RUN=$$fname" ;    \
> +                      opts=`sed -n                                     \
> +                            "s/^[^A-Z_a-z0-9]*LDOPTS *= *\(.*\)/\1/p"  \
> +                            $$src`;                                    \
> +                      targets="$$fname.o $$fname run RUN=$$fname"      \
> +                              "$(LOPT)=$$opts" ;                       \
>                    elif [ `echo $$fname | grep "\.lib"` ] ; then        \
>                        targets="$$fname$(LIBSUFFIX) $(LOPT)=" ;         \
>                    else                                                 \
> 
> 
> 


Mime
View raw message