stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject _RWSTD_VER value on trunk (was: Re: svn commit: r597396 - /incubator/stdcxx/branches/4.2.x/tests/numerics/26.valarray.cassign.cpp)
Date Wed, 12 Dec 2007 06:49:30 GMT

This has been bugging me -- when someone checks out trunk, does a build and
sends
us build results, we have no way of telling that the build results are, in
fact, for trunk and
not for 4.2.0 (or the head of 4.2.x), because the value of _RWSTD_VER is the
same. I
think we should change it so that the value is unique for each branch, or at
least distinct
from any release.

Any suggestions for what would be a good value?


Martin Sebor wrote:
> 
> faridz@apache.org wrote:
>> Author: faridz
>> Date: Thu Nov 22 04:40:33 2007
>> New Revision: 597396
>> 
>> URL: http://svn.apache.org/viewvc?rev=597396&view=rev
>> Log:
>> 2007-11-22 Farid Zaripov <farid_zaripov@epam.com>
>> 
>> 	* 26.valarray.cassign.cpp (run_test): Corrected condition in
>> preprocessor directive.
> 
> Good catch, thanks!
> 
> We should probably bump up _RWSTD_VER on trunk. To what, though?
> 
> It might also be a good idea to always set the macro so that it can't
> match that of any branch. Any ideas how to do that?
> 
> Martin
> 
>> 
>> Modified:
>>    
>> incubator/stdcxx/branches/4.2.x/tests/numerics/26.valarray.cassign.cpp
>> 
>> Modified:
>> incubator/stdcxx/branches/4.2.x/tests/numerics/26.valarray.cassign.cpp
>> URL:
>> http://svn.apache.org/viewvc/incubator/stdcxx/branches/4.2.x/tests/numerics/26.valarray.cassign.cpp?rev=597396&r1=597395&r2=597396&view=diff
>> ==============================================================================
>> ---
>> incubator/stdcxx/branches/4.2.x/tests/numerics/26.valarray.cassign.cpp
>> (original)
>> +++
>> incubator/stdcxx/branches/4.2.x/tests/numerics/26.valarray.cassign.cpp
>> Thu Nov 22 04:40:33 2007
>> @@ -805,7 +805,7 @@
>>      TEST (int);
>>      TEST (double);
>>  
>> -#if 0x04020000 <= _RWSTD_VER
>> +#if 0x04020000 >= _RWSTD_VER
>>  
>>      // test fails to compile with stdcxx 4.2.0 and prior due to
>>      // STDCXX-512: http://issues.apache.org/jira/browse/STDCXX-512
>> 
>> 
>> 
> 
> 
> 

-- 
View this message in context: http://www.nabble.com/Re%3A-svn-commit%3A-r597396----incubator-stdcxx-branches-4.2.x-tests-numerics-26.valarray.cassign.cpp-tp13905517p14289920.html
Sent from the stdcxx-dev mailing list archive at Nabble.com.


Mime
View raw message