Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 72226 invoked from network); 27 Nov 2007 01:50:29 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Nov 2007 01:50:29 -0000 Received: (qmail 10294 invoked by uid 500); 27 Nov 2007 01:50:17 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 10281 invoked by uid 500); 27 Nov 2007 01:50:17 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 10270 invoked by uid 99); 27 Nov 2007 01:50:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Nov 2007 17:50:17 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [208.30.140.160] (HELO moroha.roguewave.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Nov 2007 01:50:20 +0000 Received: from [10.70.3.143] ([10.70.3.143]) by moroha.roguewave.com (8.13.6/8.13.6) with ESMTP id lAR1nwgh029930 for ; Tue, 27 Nov 2007 01:49:58 GMT Message-ID: <474B77C7.9010400@roguewave.com> Date: Mon, 26 Nov 2007 18:49:59 -0700 From: Martin Sebor User-Agent: Thunderbird 2.0.0.9 (X11/20071031) MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: svn commit: r597665 - /incubator/stdcxx/branches/4.2.x/include/streambuf References: <20071123135153.0BDFE1A9832@eris.apache.org> In-Reply-To: <20071123135153.0BDFE1A9832@eris.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org faridz@apache.org wrote: > Author: faridz > Date: Fri Nov 23 05:51:51 2007 > New Revision: 597665 > > URL: http://svn.apache.org/viewvc?rev=597665&view=rev > Log: > 2007-11-23 Farid Zaripov > > STDCXX-307 > * streambuf (imbue): Code storing the locale moved from here... > (pubimbue): ... to here. > > Modified: > incubator/stdcxx/branches/4.2.x/include/streambuf > > Modified: incubator/stdcxx/branches/4.2.x/include/streambuf > URL: http://svn.apache.org/viewvc/incubator/stdcxx/branches/4.2.x/include/streambuf?rev=597665&r1=597664&r2=597665&view=diff > ============================================================================== > --- incubator/stdcxx/branches/4.2.x/include/streambuf (original) > +++ incubator/stdcxx/branches/4.2.x/include/streambuf Fri Nov 23 05:51:51 2007 > @@ -248,7 +248,7 @@ > > // 27.5.2.4.1, p1 > virtual void imbue (const locale &__loc) { The name of the argument should be removed if it's not used, otherwise some compilers will complain. From the recent HP aCC log: http://people.apache.org/~sebor/stdcxx/results/hpux-11.23-pa-acc-3.73-8s-597671-log.gz.txt aCC -c -I$(TOPDIR)/include -I$(BUILDDIR)/include -AA +O2 +w +W392 +W655 +W684 +W818 +W819 +W849 $(TOPDIR)/src/strstream.cpp Warning (suggestion) 431: "$(TOPDIR)/include/streambuf", line 250 # No uses of '__loc' were detected; it may be possible to remove its declaration. virtual void imbue (const locale &__loc) { ^^^^^ Martin > - _C_locale = __loc; > + // do nothing > } > > // 27.5.2.4.2, p1 > @@ -496,6 +496,7 @@ > > const locale __tmp (getloc ()); > imbue (__loc); > + _C_locale = __loc; > return __tmp; > } > > >