stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Farid Zaripov" <Farid_Zari...@epam.com>
Subject RE: [jira] Updated: (STDCXX-459) time_get::date_order() should return actually date order taken from locale
Date Thu, 29 Nov 2007 19:25:55 GMT
> -----Original Message-----
> From: Travis Vitek [mailto:Travis.Vitek@roguewave.com] 
> Sent: Thursday, November 29, 2007 7:35 PM
> To: stdcxx-dev@incubator.apache.org
> Subject: RE: [jira] Updated: (STDCXX-459) 
> time_get::date_order() should return actually date order 
> taken from locale

> The standard says the following about do_date_order()
> 
>   dateorder do_date_order() const;
> 
>   1 Returns: An enumeration value indicating the preferred order
>   of components for those date formats that are composed of day,
>   month, and year. 244) Returns no_order if the date format
>   specified by 'x' contains other variable components (e.g. Julian
>   day, week number, week day).
> 
>   224) This function is intended as a convenience only, for common
>        formats, and may return no_order in valid locales.

  Thank's for the comment. I've forget to look into standard. :(

> I think that __rw_get_dateorder() needs to handle unexpected 
> date format specifiers [such as %j, %U, %V, %w] by returning 
> no_order.

  Yes. I think replacing "case '\0':" with "default:" will be enough?

> I also think you might also want to handle %h in 
> there as it is an alias for %b.
> 
> Might there be a compatibility issue here also?

  If the compiler doesn't optimizes the virtual call of the
do_date_order(),
the proposed patch, I think, is forward and backward source and binary
compatible
because the time_get<>::do_date_order() will be defined in the library
binary file.

  There might be a functional incompatibility if the user's code want's
the only
no_order values, but receive the value other than no_order.

Farid.

Mime
View raw message