Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: stdcxx-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of Farid_Zaripov@epam.com
 designates 217.21.63.3 as permitted sender)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Subject: RE: ios_bits.cpp and MSVC
Date: Thu, 25 Oct 2007 17:28:27 +0300
Message-ID: <7BDB2168BEAEF14C98F1901FD2DE64380121F787@epmsa009.minsk.epam.com>
In-Reply-To: <471F87AD.3080202@roguewave.com>
Thread-Topic: ios_bits.cpp and MSVC
Thread-Index: AcgWZ4WhZqCJQnd0T7S+zHhxwXHRVgAqog0g
References: <7BDB2168BEAEF14C98F1901FD2DE64380121F591@epmsa009.minsk.epam.com>
 <471F87AD.3080202@roguewave.com>
From: "Farid Zaripov" <Farid_Zaripov@epam.com>
To: <stdcxx-dev@incubator.apache.org>

> -----Original Message-----
> From: Martin Sebor [mailto:sebor@roguewave.com]=20
> Sent: Wednesday, October 24, 2007 8:58 PM
> To: stdcxx-dev@incubator.apache.org
> Subject: Re: ios_bits.cpp and MSVC
>=20
> Farid Zaripov wrote:
> >   I'm working on STDCXX-437 issue and I've removed almost=20
> all MSVC 6.0=20
> > code, but I found some #if expression that I don't understand.
> >=20
> >=20
> > src/ios_bits.cpp, line 84
> > --------------------
> > #if !defined (_MSC_VER) || (_MSC_VER <=3D 1300)
> >=20
> > _RWSTD_DEFINE_STATIC_CONST (const ios_base::seekdir ios_base::beg);=20
> > _RWSTD_DEFINE_STATIC_CONST (const ios_base::seekdir ios_base::cur);=20
> > _RWSTD_DEFINE_STATIC_CONST (const ios_base::seekdir ios_base::end);
> >=20
> > #endif // !defined (_MSC_VER) || (_MSC_VER <=3D 1300)
> > --------------------
> >=20
> >   This part of code used only on non-MSVC and MSVC <=3D 7.0.
> > So these lines are excluded only on MSVC > 7.0. Why?
>=20
> I suspect it's a workaround for the following bug that first=20
> appeared in MSVC 7.0:
> http://lab.msdn.microsoft.com/ProductFeedback/viewfeedback.asp
> x?feedbackid=3Db9853206-740a-47e7-af09-b03b51934a97
>=20
> The Microsoft Feedback site gives me an error again when I=20
> try to access the page but I copied the issue from the Rogue=20
> Wave bug tracking database where we keep track of it to STDCXX-613:
>=20
> http://issues.apache.org/jira/browse/STDCXX-613

  This bug avoided in _defs.h:

_defs.h, line 1020:
-----------
#  ifndef _RWSTD_NO_STATIC_CONST_MEMBER_DEFINITION
#    define _RWSTD_DEFINE_STATIC_CONST(decl)   decl
#  else   // if defined (_RWSTD_NO_STATIC_CONST_MEMBER_DEFINITION)
     // disable defintion of static const integral members
     // to work around compiler bugs such as those in MSVC
     // or Intel C++/Windows that cause multiple definition
     // linker errors (see PR #26562 and #30260)
#    define _RWSTD_DEFINE_STATIC_CONST(ignore)   /* empty */
#  endif   // _RWSTD_NO_STATIC_CONST_MEMBER_DEFINITION
-----------

  I've commented the #if !defined (_MSC_VER) || (_MSC_VER <=3D 1300)
and corresponding #endif lines in ios_bits.cpp, and the test shows no
any errors.

Farid.