From stdcxx-dev-return-5661-apmail-incubator-stdcxx-dev-archive=incubator.apache.org@incubator.apache.org Thu Oct 18 20:44:55 2007 Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 82969 invoked from network); 18 Oct 2007 20:44:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 18 Oct 2007 20:44:55 -0000 Received: (qmail 18241 invoked by uid 500); 18 Oct 2007 20:44:33 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 18220 invoked by uid 500); 18 Oct 2007 20:44:33 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 18179 invoked by uid 99); 18 Oct 2007 20:44:33 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Oct 2007 13:44:33 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [208.30.140.160] (HELO moroha.quovadx.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Oct 2007 20:44:36 +0000 Received: from exchmail01.Blue.Roguewave.Com (exchmail01.blue.roguewave.com [10.22.129.22]) by moroha.quovadx.com (8.13.6/8.13.6) with ESMTP id l9IKfHM5000557 for ; Thu, 18 Oct 2007 20:41:17 GMT X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH] __rw_dbl_infinity ABI change with MSVC Date: Thu, 18 Oct 2007 14:42:37 -0600 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] __rw_dbl_infinity ABI change with MSVC Thread-Index: AcgRuZzQsm9XPjaqTK2jPE9mBnW9zQAB87eQ References: <4717AC02.1060504@roguewave.com> From: "Travis Vitek" To: X-Virus-Checked: Checked by ClamAV on apache.org =20 Martin Sebor wrote: >Travis Vitek wrote: >> Martin Sebor wrote: >>> Travis, while testing your updated patch, I wonder if it would be >>> possible to quickly and easily fix STDCXX-509 even for MSVC in >>> a binary compatible way by using #pragma init_seg to initialize >>> the constants before any user-defined objects? >>> >>> http://msdn2.microsoft.com/en-us/library/7977wcck(VS.71).aspx >>> http://msdn2.microsoft.com/en-us/library/7977wcck(VS.80).aspx >>> >>> Martin >>=20 >> Yes, I think this is okay. I've attached a patch that includes this >> change. I also added a rather ugly macro to use to guard=20 >> this stuff to avoid repeating the crazy logic in multiple places. > >Okay, thanks. Now I just need the ChangeLog. 2007-10-18 Travis Vitek STDCXX-509 * rw/_config.h [_RWSTD_VER_MAJOR]: Define macro for workaround for binary compatbility issues with msvc. * include/limits: Avoid creating binary compatibility issue. * src/limits_bits.cpp: Ditto. > >Btw., how did you test this? I haven't found a way to verify that the symbols are being initialized at the appropriate time. I have tested the examples on builds of both msvc-7.1 and msvc-8.0 to verify that I haven't broken anything obvious. > >And did you by any chance apply >Farid's patch for the exception symbols (with the correction >for the stdcxx version)? > Yes, the patch for the exception stuff was done seperately. >Martin > >