From stdcxx-dev-return-4799-apmail-incubator-stdcxx-dev-archive=incubator.apache.org@incubator.apache.org Thu Sep 06 19:04:44 2007 Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 4131 invoked from network); 6 Sep 2007 19:04:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Sep 2007 19:04:36 -0000 Received: (qmail 4878 invoked by uid 500); 6 Sep 2007 19:04:28 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 4859 invoked by uid 500); 6 Sep 2007 19:04:28 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 4848 invoked by uid 99); 6 Sep 2007 19:04:28 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Sep 2007 12:04:28 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [208.30.140.160] (HELO moroha.quovadx.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Sep 2007 19:04:25 +0000 Received: from qxvcexch01.ad.quovadx.com ([192.168.170.59]) by moroha.quovadx.com (8.13.6/8.13.6) with ESMTP id l86J420k015820 for ; Thu, 6 Sep 2007 19:04:02 GMT Received: from [10.70.3.113] ([10.70.3.113]) by qxvcexch01.ad.quovadx.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 6 Sep 2007 13:03:04 -0600 Message-ID: <46E04F22.3040904@roguewave.com> Date: Thu, 06 Sep 2007 13:04:02 -0600 From: Martin Sebor Organization: Rogue Wave Software, Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: svn commit: r573328 - /incubator/stdcxx/trunk/include/rw/_traits.h References: <20070906180424.70E011A9832@eris.apache.org> In-Reply-To: <20070906180424.70E011A9832@eris.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 06 Sep 2007 19:03:04.0305 (UTC) FILETIME=[8D906E10:01C7F0B8] X-Virus-Checked: Checked by ClamAV on apache.org lnicoara@apache.org wrote: > Author: lnicoara > Date: Thu Sep 6 11:04:23 2007 > New Revision: 573328 Great, thanks. Now if you could also add the test case to the regression suite that would be swell :) > > URL: http://svn.apache.org/viewvc?rev=573328&view=rev > Log: > 2007-09-06 Liviu Nicoara > > * rw/_traits.h: added cast to unsigned char You forgot the reference to the issue that this change fixes (in both Change Logs), and the name of the function you modified. I should have pointed that out (and you should have read the Patch Format section on the Bugs page: http://incubator.apache.org/stdcxx/bugs.html#patch_format). Here's what the Change Log should have looked like: 2007-09-06 Liviu Nicoara STDCXX-541 * _traits.h (find): Added cast to unsigned char to prevent sign extension when char is a signed type. Martin > > > Modified: > incubator/stdcxx/trunk/include/rw/_traits.h > > Modified: incubator/stdcxx/trunk/include/rw/_traits.h > URL: http://svn.apache.org/viewvc/incubator/stdcxx/trunk/include/rw/_traits.h?rev=573328&r1=573327&r2=573328&view=diff > ============================================================================== > --- incubator/stdcxx/trunk/include/rw/_traits.h (original) > +++ incubator/stdcxx/trunk/include/rw/_traits.h Thu Sep 6 11:04:23 2007 > @@ -406,8 +406,9 @@ > // cast to const void* used to get around a gcc 2.95 bug > // that prevents a static_cast from void* --> const T* > // (only occurs if memchr() isn't overloaded on const) > - return _RWSTD_STATIC_CAST (const char_type*, > - (const void*)_RWSTD_MEMCHR (__s, __c, __n)); > + return _RWSTD_STATIC_CAST ( > + const char_type*, (const void*)_RWSTD_MEMCHR ( > + __s, _RWSTD_STATIC_CAST (unsigned char, __c), __n)); > } > > static _RWSTD_SIZE_T length (const char_type *__s) { > >