stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Farid Zaripov" <Farid_Zari...@epam.com>
Subject RE: svn commit: r575614 - /incubator/stdcxx/trunk/tests/regress/22.locale.stdcxx-554.cpp
Date Tue, 18 Sep 2007 18:14:17 GMT
> -----Original Message-----
> From: Martin Sebor [mailto:msebor@gmail.com] On Behalf Of Martin Sebor
> Sent: Saturday, September 15, 2007 11:34 PM
> To: stdcxx-dev@incubator.apache.org
> Subject: Re: svn commit: r575614 - 
> /incubator/stdcxx/trunk/tests/regress/22.locale.stdcxx-554.cpp
> 
> faridz@apache.org wrote:
> > Author: faridz
> > Date: Fri Sep 14 03:49:31 2007
> > New Revision: 575614
> > 
> > URL: http://svn.apache.org/viewvc?rev=575614&view=rev
> > Log:
> > 2007-09-14 Farid Zaripov <Farid_Zaripov@epam.com>
> > 
> > 	* 22.locale.stdcxx-554.cpp: Added a regression test for 
> STDCXX-554.
> 
> Good job narrowing it down to a small test case!
> 
> Unless there's no easy way to write the test without 
> involving the driver I think we said regression tests would 
> not depend on it and use the assert macro instead.

  Done: http://svn.apache.org/viewvc?rev=577001&view=rev

> Since the regular unit test exercises the same functionality and 
> uncovers the bug I don't think the regression test is 
> strictly speaking necessary (I'm certainly okay with keeping 
> it without the rwtest dependency).

  The regular test doesn't exercises this bug. The bug was catched
by MSVC runtime checks, but not by the test assertions.

Farid.

Mime
View raw message