stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: [PATCH] time_put.cpp
Date Fri, 28 Sep 2007 02:02:31 GMT
Farid Zaripov wrote:
>   The MSVC issues parameter validation error in
> 22.locale.time.put.mt.cpp test.

This is good.

Please just hold off on committing it until after the merge. I've
been having problems with Subversion all day. svn merge fails with
an error for each file that's been added on trunk since the last
merge. For example:

svn: Access scheme mixtures not yet supported 
('http://svn.apache.org/repos/asf/incubator/stdcxx/trunk/tests/regress/23.vector.bool.stdcxx-235.cpp'

and 
'https://svn.apache.org/repos/asf/incubator/stdcxx/branches/4.2.0/tests/regress')

I've been copying these files manually, and then restarting
the merge from scratch. It's taken me all day! The lesson to
be learned from this: never wait this long between merges!

Martin

> 
> The parameter checking code below:
> ---------
> int (isspace) (int c)
> {
>     _ASSERTE((unsigned)(c + 1) <= 256);
>     ...
> }
> ---------
> 
>   The same validation performed in all isxxx() functions. This
> validation asserts on all c < -1.
> 
>   The patch is attached.
> 
>   ChangeLog:
>   * time_put.cpp (__rw_get_date_fmat): Convert char argument of
> isspace(), isdigit(), ispunct() to unsigned char .
>   (__rw_get_time_fmat): Ditto.
> 
> Farid.
> 


Mime
View raw message