stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Travis Vitek (JIRA)" <j...@apache.org>
Subject [jira] Commented: (STDCXX-413) 22.locale.money.get.cpp doesn't test international monetary formats
Date Wed, 05 Sep 2007 03:56:45 GMT

    [ https://issues.apache.org/jira/browse/STDCXX-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524967
] 

Travis Vitek commented on STDCXX-413:
-------------------------------------

The patched test sets the moneypunct facet formatting information to a known state [for both
local and international], and then attempts to extract values out of fixed strings for which
the result is known. This is exactly what was being done previously for local money data.
This patch just adds the ability to verify the international formatted data. i.e. the test
essentially does this

  1. set currency symbol for local to "YEN"
  2. set currency symbol for international to NULL
  3. attempt to read local money from "YEN 10"
  4. set currency symbol for international to "YEN"
  5. set currency symbol for local to NULL
  6. attempt to read international money from "YEN 10"

If you would like me to add a new test, or expand the existing test, to do a round trip for
money values for user provided locales, I would be happy to.


> 22.locale.money.get.cpp doesn't test international monetary formats
> -------------------------------------------------------------------
>
>                 Key: STDCXX-413
>                 URL: https://issues.apache.org/jira/browse/STDCXX-413
>             Project: C++ Standard Library
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 4.1.3
>            Reporter: Mark Brown
>            Assignee: Travis Vitek
>             Fix For: 4.2
>
>         Attachments: money.get.patch
>
>
> The test 22.locale.money.get.cpp doesn't exercise international monetary formats. See:
> -----Original Message-----
> From: sebor@roguewave.com
> Sent: Sat, 12 May 2007 15:42:16 -0600
> To: stdcxx-dev@incubator.apache.org
> Subject: Re: svn commit: r537492 - /incubator/stdcxx/trunk/doc/stdlibref/money-get.html
> Mark Brown wrote:
> >> -----Original Message-----
> >> From: sebor@roguewave.com
> >> Sent: Sat, 12 May 2007 14:09:34 -0600
> >> To: stdcxx-dev@incubator.apache.org
> >> Subject: Re: svn commit: r537492 -
> >> /incubator/stdcxx/trunk/doc/stdlibref/money-get.html
> >>
> >> Mark Brown wrote:
> >>> Martin,
> >>>
> >>> Thanks for fixing it! I have a question about the new code: Could you
> >>> show an example of an international monetary string that would be
> >>> correctly parsed by the facet? I tried a few but none of them could be
> >>> parsed. For instance, "USD 1234" gives this output:
> >>> USD 1234 --> "" --> 0
> >>> The same happens with g++ and STLport so I suspect I must be doing
> >>> something wrong. Removing the space between the currency symbol and the
> >>> number didn't make a difference.
> >> Hmm, I guess I should have tested the internationalized behavior before
> >> I put it in. I think the code is correct as is and your input should be
> >> correctly parsed by the facet (and produce 1234 on output). I'm not sure
> >> what's going on. Stepping through the code it looks like the money_get
> >> facet ends up retrieving the wrong specialization of moneypunct, i.e.,
> >> moneypunct<char, false> when it needs moneypunct<char, true>. What's
> >> puzzling is that both libstdc++ and STLport behave the same. It seems
> >> like too much of a coincidence for all three implementations to suffer
> >> from the same bug.
> >>
> >> In any event, thanks for bringing it to our attention! Can you open an
> >> issue for this as well so we don't forget to investigate it in case I
> >> don't get around to it soon?
> > 
> > I can certainly do that. I should also mention that while investigating this problem
I found a test that's supposed to test this functionality: 22.locale.money.get.cpp. The test
fails 20 out of 1934 assertions but none of them look like they have anything to do with parsing
international monetary values. It doesn't look like they are being tested at all...
> Yeah, I noticed it too. I'm in the process of enhancing the test to
> exercise the international formats as well. If you don't mind creating
> another issue for the test, just for tracking purposes, that would be
> swell!
> Martin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message