Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: stdcxx-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: local policy)
Message-ID: <46C1CE7F.5020702@roguewave.com>
Date: Tue, 14 Aug 2007 09:47:11 -0600
From: Martin Sebor <sebor@roguewave.com>
Organization: Rogue Wave Software, Inc.
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
 rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4
MIME-Version: 1.0
To: stdcxx-dev@incubator.apache.org
Subject: Re: [PATCH] STDCXX-515
References: <7BDB2168BEAEF14C98F1901FD2DE6438C9161C@epmsa009.minsk.epam.com>
In-Reply-To: <7BDB2168BEAEF14C98F1901FD2DE6438C9161C@epmsa009.minsk.epam.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Farid Zaripov wrote:
>   Below is the patch for fix STDCXX-515.
> 
>   ChangeLog:
>   * sstream.cc (xsputn): Correct write position after growing the
> buffer.

Why do we need to do it in xsputn()? Isn't str() supposed to keep
pptr() at the right offset after growing the buffer?

Martin

> 
> Index: sstream.cc
> ===================================================================
> --- sstream.cc	(revision 564229)
> +++ sstream.cc	(working copy)
> @@ -185,10 +185,16 @@
>          const _RWSTD_SIZE_T __bufsize =
>              __n + (this->pptr () - this->pbase ());
>  
> +        // preserve current pptr() since str() would seek to end
> +        const streamsize __cur = this->pptr () - this->pbase ();
> +
>          // grow the buffer if necessary to accommodate the whole
>          // string plus the contents of the buffer up to pptr()
>          str (this->_C_buffer, __bufsize);
>  
> +        // restore pptr()
> +        this->pbump (__cur - (this->pptr () - this->pbase ()));
> +
>          _RWSTD_ASSERT (__n <= this->epptr () - this->pptr ());
>      }
>  
> 
> Farid.