From stdcxx-dev-return-4320-apmail-incubator-stdcxx-dev-archive=incubator.apache.org@incubator.apache.org Tue Aug 14 02:27:35 2007 Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 62630 invoked from network); 14 Aug 2007 02:27:33 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 14 Aug 2007 02:27:33 -0000 Received: (qmail 76938 invoked by uid 500); 14 Aug 2007 02:27:32 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 76879 invoked by uid 500); 14 Aug 2007 02:27:32 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 76868 invoked by uid 99); 14 Aug 2007 02:27:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Aug 2007 19:27:31 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [208.30.140.160] (HELO moroha.quovadx.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Aug 2007 02:27:41 +0000 Received: from qxvcexch01.ad.quovadx.com ([192.168.170.59]) by moroha.quovadx.com (8.13.6/8.13.6) with ESMTP id l7E2R5xA017419 for ; Tue, 14 Aug 2007 02:27:05 GMT X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH] Update test 22.locale.num.put.mt.cpp to validate results [take 2] Date: Mon, 13 Aug 2007 20:26:05 -0600 Message-ID: In-Reply-To: <46BFD340.5020701@roguewave.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] Update test 22.locale.num.put.mt.cpp to validate results [take 2] Thread-Index: AcfdXDC3agccTU/+R16FxGNHrRYlcAAu+/Hg References: <46BFD340.5020701@roguewave.com> From: "Travis Vitek" To: X-Virus-Checked: Checked by ClamAV on apache.org =20 Martin Sebor wrote: > >> =20 >> +#define countof(x) (sizeof (x) / sizeof (*x)) > >Since you seem to like it so much ;-) we might as well move this >macro to some central test suite header (and rename it according >to the naming convention). > I'd love to, provided that we can define the naming convention to be used for macros in the test suite. The style guide I've seen has guidelines for names in the stdcxx implementation. I wouldn't think that we would want the same convention used for macros defined in the implementation as for macros defined within the test harness. The only macros that appear to be named consistently are the header guards. The names of other macros are pretty inconsistent. I'm guessing that you want it to be underscore seperated uppercase, which is fine by me. Some of the macros match this convention, of course many of them don't. Some start with RW, others with _RWSTD or _TEST, and quite a few of them don't have a prefix at all. How does adding _TEST_COUNT_OF(x) to the bottom of testdefs.h sound? Travis