From stdcxx-dev-return-4146-apmail-incubator-stdcxx-dev-archive=incubator.apache.org@incubator.apache.org Fri Aug 03 16:53:19 2007 Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 69371 invoked from network); 3 Aug 2007 16:53:19 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Aug 2007 16:53:19 -0000 Received: (qmail 75204 invoked by uid 500); 3 Aug 2007 16:53:19 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 75188 invoked by uid 500); 3 Aug 2007 16:53:19 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 75172 invoked by uid 99); 3 Aug 2007 16:53:18 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Aug 2007 09:53:18 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of Farid_Zaripov@epam.com designates 217.21.63.3 as permitted sender) Received: from [217.21.63.3] (HELO EPMSA009.epam.com) (217.21.63.3) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Aug 2007 16:53:15 +0000 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: RE: svn commit: r562224 - in /incubator/stdcxx/trunk/util: display.cpp display.h exec.cpp runall.cpp target.h util.cpp util.h Date: Fri, 3 Aug 2007 19:52:52 +0300 Message-ID: <7BDB2168BEAEF14C98F1901FD2DE6438C90DF2@epmsa009.minsk.epam.com> In-Reply-To: <46B34B6E.2040504@roguewave.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: svn commit: r562224 - in /incubator/stdcxx/trunk/util: display.cpp display.h exec.cpp runall.cpp target.h util.cpp util.h Thread-Index: AcfV5BgWwFWg6jU+R/Kw4YluduN0JwACcPMg References: <20070802190428.BD1C11A981A@eris.apache.org> <46B34B6E.2040504@roguewave.com> From: "Farid Zaripov" To: X-Virus-Checked: Checked by ClamAV on apache.org > -----Original Message----- > From: Andrew Black [mailto:ablack@roguewave.com]=20 > Sent: Friday, August 03, 2007 6:36 PM > To: stdcxx-dev@incubator.apache.org > Subject: Re: svn commit: r562224 - in=20 > /incubator/stdcxx/trunk/util: display.cpp display.h exec.cpp=20 > runall.cpp target.h util.cpp util.h >=20 > Something in this patch appears to cause the exec utility to=20 > hang on Windows. I haven't had much time to dig into the=20 > cause, but I thought I'd give everyone a heads up. Farid, if=20 > you have a chance, could you look into this? The exec process deadlocked in (exec.cpp, line 1055): ----- warn_last_error ("Opening child input stream"); ----- after the CreateFile (options->infname) has failed (because options->infname =3D=3D "/dev/null"). The proposed fix below, but deadlocking is the another issue to be resolved: Index: util.cpp =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- util.cpp (revision 562407) +++ util.cpp (working copy) @@ -200,9 +200,15 @@ free (fname); } =20 +#ifndef _WIN32 +#define DEV_NULL "/dev/null" +#else +#define DEV_NULL "NUL" +#endif + /* If we didn't find a source file, use /dev/null */ - fname =3D (char*)RW_MALLOC (sizeof "/dev/null"); - strcpy (fname, "/dev/null"); + fname =3D (char*)RW_MALLOC (sizeof DEV_NULL); + strcpy (fname, DEV_NULL); return fname; } =20 Farid.