From stdcxx-dev-return-4283-apmail-incubator-stdcxx-dev-archive=incubator.apache.org@incubator.apache.org Fri Aug 10 18:29:55 2007 Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 48405 invoked from network); 10 Aug 2007 18:29:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 10 Aug 2007 18:29:55 -0000 Received: (qmail 84313 invoked by uid 500); 10 Aug 2007 18:29:53 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 84297 invoked by uid 500); 10 Aug 2007 18:29:53 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 84285 invoked by uid 99); 10 Aug 2007 18:29:53 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Aug 2007 11:29:53 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [208.30.140.160] (HELO moroha.quovadx.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Aug 2007 18:29:49 +0000 Received: from qxvcexch01.ad.quovadx.com ([192.168.170.59]) by moroha.quovadx.com (8.13.6/8.13.6) with ESMTP id l7AITR3q012067 for ; Fri, 10 Aug 2007 18:29:27 GMT Received: from [10.70.3.113] ([10.70.3.113]) by qxvcexch01.ad.quovadx.com with Microsoft SMTPSVC(6.0.3790.1830); Fri, 10 Aug 2007 12:28:46 -0600 Message-ID: <46BCAEAA.5070909@roguewave.com> Date: Fri, 10 Aug 2007 12:30:02 -0600 From: Martin Sebor Organization: Rogue Wave Software, Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.2) Gecko/20070221 SeaMonkey/1.1.1 MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: svn commit: r564698 - /incubator/stdcxx/trunk/include/rw/_mutex.h References: <20070810180055.577C61A981A@eris.apache.org> In-Reply-To: <20070810180055.577C61A981A@eris.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 10 Aug 2007 18:28:46.0185 (UTC) FILETIME=[49ACFD90:01C7DB7C] X-Virus-Checked: Checked by ClamAV on apache.org faridz@apache.org wrote: > Author: faridz > Date: Fri Aug 10 11:00:54 2007 > New Revision: 564698 > > URL: http://svn.apache.org/viewvc?view=rev&rev=564698 > Log: > 2007-08-10 Farid Zaripov > > * _mutex.h (__rw_atomic_preincrement) [_WIN32]: Cast __x to int& instead of long& > to use InterlockedIncrement() optimized function instead of generic one using > critical sections. Really? The long overload should do the "right thing" when long and int are the same size. If it doesn't it's our bug. Martin > > Modified: > incubator/stdcxx/trunk/include/rw/_mutex.h > > Modified: incubator/stdcxx/trunk/include/rw/_mutex.h > URL: http://svn.apache.org/viewvc/incubator/stdcxx/trunk/include/rw/_mutex.h?view=diff&rev=564698&r1=564697&r2=564698 > ============================================================================== > --- incubator/stdcxx/trunk/include/rw/_mutex.h (original) > +++ incubator/stdcxx/trunk/include/rw/_mutex.h Fri Aug 10 11:00:54 2007 > @@ -1371,7 +1371,7 @@ > inline unsigned int > __rw_atomic_preincrement (unsigned int &__x, bool) > { > - return __rw_atomic_preincrement (_RWSTD_REINTERPRET_CAST (long&, __x), > + return __rw_atomic_preincrement (_RWSTD_REINTERPRET_CAST (int&, __x), > false); > } > > >