stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Travis Vitek" <>
Subject RE: [PATCH] Update test to validate results
Date Wed, 08 Aug 2007 00:37:21 GMT

>Martin Sebor wrote:
>It looks like Outlook is even more braindead than I thought. It
>encoded the plain text attachment in base64, so there's no easy
>way to comment on it. Sigh. I had to copy the patch to an email
>and send it to myself to get the ticks ('>') so that my comments
>wouldn't get mixed up with the patch. Travis, you need to get
>yourself a decent mailer :) Anything but Outlook.

I'll apply the suggested changes, verify on gcc, and submit the patch
again using a mailer on the unix side.

> > +    // avoid divide by zero in thread if there are no 
>locales to test
> > +    if (nlocales < 1) {
> > +        rw_fatal(nlocales != 0, 0, __LINE__,
> > +                 "failed to create one or more usable locales");
>There are systems with no locales installed. I think we just want
>rw_warn() here, not something as severe as rw_fatal(). (And we
>want a space before the open paren :)

Not exactly sure what you want here. I can put an rw_warn() followed
immediately by a return, or I can have each thread test the number of
locales again and bail early. If the threads are allowed to run, they
will all fail with a div-by-zero when they try to mod by 'nlocales'.


View raw message