stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: comments on 22.locale.money.get.mt.cpp
Date Tue, 28 Aug 2007 01:16:26 GMT
Martin Sebor wrote:
> Hi Travis,
> 
> This test looks good to commit. Just a couple of comments or
> questions: would it make sense to introduce a helper function
> template to call the get_xxx() member and factor out the case
> and switch statements in run_test() and in thread_func() into
> it?
> 
> Also, the test seems to take *really* long to run on the Linux
> box where I'm testing it. I suspect it'll end up timing out on
> most platforms. Have you tried to tweak the numbers of locales
> and/or iterations to reduce the runtime? If not, I think we'll
> need to tweak a few things to make it run faster. We can do
> that in a follow-up change though.

For the record, the *really* long runtime turned out to be
a deadlock possibly caused by my local changes to the library.
When compiled against trunk, the test still runs pretty long
but eventually usually crashes.

In any event, I committed your test thus:
http://svn.apache.org/viewvc?rev=570286&view=rev

Btw., I forgot to reference the task in the Change Log, which
in addition to annoying me :) also reminded me that our policy
is for contributors to submit Change Logs along with their
patches. So, please add Change Logs to all the STDCXX-526
subtasks so that next time it happens I have someone else
to blame ;-)

http://incubator.apache.org/stdcxx/bugs.html#patch_format

Martin

> 
> Martin
> 
> Travis Vitek (JIRA) wrote:
>>      [ 
>> https://issues.apache.org/jira/browse/STDCXX-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

>> ]
>>
>> Travis Vitek resolved STDCXX-528.
>> ---------------------------------
>>
>>     Resolution: Fixed
>>
>>> create test 22.locale.money.get.mt.cpp
>>> --------------------------------------
>>>
>>>                 Key: STDCXX-528
>>>                 URL: https://issues.apache.org/jira/browse/STDCXX-528
>>>             Project: C++ Standard Library
>>>          Issue Type: Sub-task
>>>          Components: 22. Localization, Thread Safety
>>>    Affects Versions: 4.1.2, 4.1.3, 4.1.4
>>>            Reporter: Travis Vitek
>>>            Assignee: Travis Vitek
>>>             Fix For: 4.2
>>>
>>>         Attachments: 22.locale.money.get.mt.cpp
>>>
>>>
>>
>>
> 


Mime
View raw message