stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: [PATCH] gencat.cpp
Date Fri, 03 Aug 2007 14:50:55 GMT
Farid Zaripov wrote:
>> -----Original Message-----
>> From: Martin Sebor [mailto:sebor@roguewave.com] 
>> Sent: Friday, August 03, 2007 2:03 AM
>> To: stdcxx-dev@incubator.apache.org
>> Subject: Re: [PATCH] gencat.cpp (was: RE: svn commit: r555006 
>> - /incubator/stdcxx/trunk/src/catalog.cpp)
>>
>> This looks good, although it could use a few more comments :)
>>
>> Where does it live? In $TOPDIR/util/?
>   Yes.
> 
>> Does the conditional #error cause any problems on UNIX?
>   We can exclude this file from compilation (the same way as
> excluded rwstdmessages.cpp in makefile.exm).
>   
>> Would it be safer to implement it on UNIX as well by having it
>> invoke the system gencat utility?
>   Yes we can do it, but with renaming the utility to, for example,
> rwgencat
> to avoid invoking the utility recursively.

Or by specifying the full pathname when invoking the system
gencat utility. Or simply by removing $BUILDDIR/bin from PATH
if it's there.

If you think this approach will work I would favor it over
changing the makefiles and avoiding building the utility on
UNIX.

Does anyone have any concerns or suggestions? Andrew? Travis?

Martin

Mime
View raw message