Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: stdcxx-dev@incubator.apache.org
Received-SPF: pass (herse.apache.org: domain of msebor@gmail.com designates
 209.85.146.179 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:organization:user-agent:mime-version:to:subject:references:in-reply-to:content-type:content-transfer-encoding:sender;
        b=jQHEy8isz9oNng5ijtM9iMU1GhVPc+vpE1WPPfF0H0HNvP1dubYQN1XxUFyonqWfzQaykaj7kX3HuKVGSflAQhpwjpyCahqBKC/mRV3uOW7T5OLbzSQFcoNsr1JByOzQ2UW/1edgGasEExVpIbnWJui2gT2lQb9ED93mVT8xbGA=
Message-ID: <469D659C.3020201@roguewave.com>
Date: Tue, 17 Jul 2007 18:58:04 -0600
From: Martin Sebor <sebor@roguewave.com>
Organization: Rogue Wave Software
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
 rv:1.8.0.12) Gecko/20070531 Fedora/1.0.9-1.fc6 pango-text SeaMonkey/1.0.9
MIME-Version: 1.0
To: stdcxx-dev@incubator.apache.org
Subject: Re: [patch] STDCXX-170
References: <7BDB2168BEAEF14C98F1901FD2DE6438B00AA5@epmsa009.minsk.epam.com>
In-Reply-To: <7BDB2168BEAEF14C98F1901FD2DE6438B00AA5@epmsa009.minsk.epam.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: Martin Sebor <msebor@gmail.com>

Farid Zaripov wrote:
>   Here is proposed patch to fix STDCXX-170 issue:
>  
>   ChangeLog:
>   * string.cc (replace): Copy data to temporary string object
>   if data is a part of the internal string buffer.
>  
> Index: string.cc
> ===================================================================
> --- string.cc (revision 556830)
> +++ string.cc (working copy)
> @@ -516,6 +516,15 @@
>      _RWSTD_ASSERT_RANGE (__first1, __last1);
>      _RWSTD_ASSERT_RANGE (__first2, __last2);
>  
> +    if (   !(__first2 == __last2)
> +        && __s._C_data <= &*__first2
> +        && __s._C_data + __s.size () > &*__first2) {

I don't think this exression is guaranteed to be well-formed.
InputIterator's operator* can return an rvalue (rather than
a const reference) which would break operator &. The test
case below should compile. Does it with your change?

It should also run successfully to completion but in debug
builds it aborts instead. That looks like a bug in our
implementation of the debugging iterators.

#include <iterator>
#include <string>

struct Iterator: std::string::const_reverse_iterator
{
     char operator* () const {
         return std::string::const_reverse_iterator::operator* ();
     }
};

int main ()
{
     std::string s;
     s.replace (s.begin (), s.end (), Iterator (), Iterator ());
}

Martin

> +
> +        // __first2 points to internal string buffer
> +        return __s.replace (__first1, __last1,
> +                            basic_string (__first2, __last2));
> +    }
> +
>       // use a (probably) faster algorithm if possible
>       if
> (_STD::__is_bidirectional_iterator(_RWSTD_ITERATOR_CATEGORY(_InputIter,
>  
> __last2)))
> 
>  
> Farid.
>