Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: stdcxx-dev@incubator.apache.org
Received-SPF: pass (herse.apache.org: domain of Farid_Zaripov@epam.com
 designates 217.21.63.3 as permitted sender)
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Subject: RE: svn commit: r549586 - /incubator/stdcxx/trunk/src/exception.cpp
Date: Fri, 22 Jun 2007 10:26:35 +0300
Message-ID: <7BDB2168BEAEF14C98F1901FD2DE64389D67F8@epmsa009.minsk.epam.com>
In-Reply-To: <467B1191.9020106@roguewave.com>
Thread-Topic: svn commit: r549586 - /incubator/stdcxx/trunk/src/exception.cpp
Thread-Index: Ace0YHL7D0NNZVsWTnelu61WOvtAYwAPNe7Q
References: <20070621185142.2B1C91A981A@eris.apache.org>
 <467B1191.9020106@roguewave.com>
From: "Farid Zaripov" <Farid_Zaripov@epam.com>
To: <stdcxx-dev@incubator.apache.org>

> -----Original Message-----
> From: Martin Sebor [mailto:sebor@roguewave.com]=20
> Sent: Friday, June 22, 2007 3:02 AM
> To: stdcxx-dev@incubator.apache.org
> Subject: Re: svn commit: r549586 -=20
> /incubator/stdcxx/trunk/src/exception.cpp
>=20
> As you astutely observed in a previous discussion of the=20
> issue (at the link below), "__rw_free_what_buf() should be=20
> extern _RWSTD_EXPORT, to be accessible by user in overridden=20
> __rw_throw_proc()" otherwise there will be no way for users=20
> to avoid a leak in their replacement __rw_throw_proc().
>=20
>
http://www.mail-archive.com/stdcxx-dev@incubator.apache.org/msg02192.htm
l

  Yes, I remember that. This would be separated patch.

> Also, while it's too late to fix it for this commit, the=20
> ChangeLog entry is missing a reference to the Jira issue=20
> number it resolves.
> Please remember to include it future changes, especially=20
> those to the library.

  The bug-fixing patch was here:
http://svn.apache.org/viewvc?view=3Drev&rev=3D549584

  Anyway that patch is also related to the STDCXX-293, and is
never late to correct the ChangeLog :)
http://www.mail-archive.com/stdcxx-commits@incubator.apache.org/msg01322
.html

Farid.