Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: stdcxx-dev@incubator.apache.org
Received-SPF: pass (herse.apache.org: local policy)
Message-ID: <46804215.5040102@roguewave.com>
Date: Mon, 25 Jun 2007 16:30:45 -0600
From: Martin Sebor <sebor@roguewave.com>
Organization: Rogue Wave Software
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
 rv:1.8.1.2) Gecko/20070221 SeaMonkey/1.1.1
MIME-Version: 1.0
To: stdcxx-dev@incubator.apache.org
Subject: Re: Convert MSVC CRT debug reports to rwtest driver debug reports
References: <7BDB2168BEAEF14C98F1901FD2DE64389D6B99@epmsa009.minsk.epam.com>
In-Reply-To: <7BDB2168BEAEF14C98F1901FD2DE64389D6B99@epmsa009.minsk.epam.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Farid Zaripov wrote:
>   In some tests in debug mode GUI popups appear.
>   We can disable this popups by using _CrtSetReportMode(,
> _CRTDBG_MODE_DEBUG), but I think
> it would be useful to convert them into the rwtest debug reports
> (rw_warn(), rw_error(), rw_assert()).
> This conversion can be made by installing custom hook function.

Sounds reasonable, but I'd like to know a little bit more about
what types of errors we're dealing with here.

Which of the three types of diagnostics does your patch convert
them to? I think rw_error() would be appropriate for undefined
behavior like memory corruption detected by the CRT, etc. What
other types of errors cause these popups?

>  
>   And also MSVC8 CRT performs parameter checking with invoking Dr.Watson
> tool (the result is GUI
> popup) in case the invalid parameter was passed to the CRT function. I
> suggest to convert this popups
> to the rw_note() reports (or maybe rw_error()).

In terms of the severity, rw_note() is quite different from
rw_error(), so it's important to understand what types of errors
we're dealing with. Can you give more detail about these invalid
parameter errors, or a few examples?

>  
>   The proposed patch below:

It would be helpful to see a ChangeLog entry for the patch.

Thanks
Martin