stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: svn commit: r549586 - /incubator/stdcxx/trunk/src/exception.cpp
Date Fri, 22 Jun 2007 15:06:54 GMT
Farid Zaripov wrote:
>> -----Original Message-----
>> From: Martin Sebor [mailto:sebor@roguewave.com] 
>> Sent: Friday, June 22, 2007 3:02 AM
>> To: stdcxx-dev@incubator.apache.org
>> Subject: Re: svn commit: r549586 - 
>> /incubator/stdcxx/trunk/src/exception.cpp
>>
>> As you astutely observed in a previous discussion of the 
>> issue (at the link below), "__rw_free_what_buf() should be 
>> extern _RWSTD_EXPORT, to be accessible by user in overridden 
>> __rw_throw_proc()" otherwise there will be no way for users 
>> to avoid a leak in their replacement __rw_throw_proc().
>>
>>
> http://www.mail-archive.com/stdcxx-dev@incubator.apache.org/msg02192.htm
> l
> 
>   Yes, I remember that. This would be separated patch.

Gotcha! Let's make sure to do that (or open a new issue).

> 
>> Also, while it's too late to fix it for this commit, the 
>> ChangeLog entry is missing a reference to the Jira issue 
>> number it resolves.
>> Please remember to include it future changes, especially 
>> those to the library.
> 
>   The bug-fixing patch was here:
> http://svn.apache.org/viewvc?view=rev&rev=549584

Ah, okay.

> 
>   Anyway that patch is also related to the STDCXX-293, and is
> never late to correct the ChangeLog :)
> http://www.mail-archive.com/stdcxx-commits@incubator.apache.org/msg01322
> .html

We can change the ChangeLog this way but it won't make the Jira
Subversion plugin pick up the reference to the patch so the patch
won't show up on the Subversion Commits tab. See
https://issues.apache.org/jira/browse/INFRA-624

Martin

Mime
View raw message