stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: svn commit: r549586 - /incubator/stdcxx/trunk/src/exception.cpp
Date Fri, 22 Jun 2007 00:02:25 GMT
Hi Farid,

As you astutely observed in a previous discussion of the issue
(at the link below), "__rw_free_what_buf() should be extern
_RWSTD_EXPORT, to be accessible by user in overridden
__rw_throw_proc()" otherwise there will be no way for users
to avoid a leak in their replacement __rw_throw_proc().

http://www.mail-archive.com/stdcxx-dev@incubator.apache.org/msg02192.html

Also, while it's too late to fix it for this commit, the ChangeLog
entry is missing a reference to the Jira issue number it resolves.
Please remember to include it future changes, especially those to
the library.

Thanks
Martin

faridz@apache.org wrote:
> Author: faridz
> Date: Thu Jun 21 11:51:41 2007
> New Revision: 549586
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=549586
> Log:
> 2007-06-21 Farid Zaripov <Farid_Zaripov@epam.com>
> 
> 	* exception.cpp (__rw_throw): Don't delete allocated what string because of
> 	__rw_throw_proc() takes ownership and must delete what string.
> 
> Modified:
>     incubator/stdcxx/trunk/src/exception.cpp
> 
> Modified: incubator/stdcxx/trunk/src/exception.cpp
> URL: http://svn.apache.org/viewvc/incubator/stdcxx/trunk/src/exception.cpp?view=diff&rev=549586&r1=549585&r2=549586
> ==============================================================================
> --- incubator/stdcxx/trunk/src/exception.cpp (original)
> +++ incubator/stdcxx/trunk/src/exception.cpp Thu Jun 21 11:51:41 2007
> @@ -827,9 +827,6 @@
>  
>          // throw_proc takes ownership of allocated string
>          __rw_throw_proc (id, what);
> -
> -        // if throw_proc returns, delete allocated what string
> -        __rw_free_what_buf (what);
>      }
>  }
>  
> 
> 


Mime
View raw message