From stdcxx-dev-return-2820-apmail-incubator-stdcxx-dev-archive=incubator.apache.org@incubator.apache.org Mon Mar 12 16:31:38 2007 Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 52968 invoked from network); 12 Mar 2007 16:31:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 12 Mar 2007 16:31:37 -0000 Received: (qmail 65376 invoked by uid 500); 12 Mar 2007 16:31:46 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 65367 invoked by uid 500); 12 Mar 2007 16:31:46 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 65347 invoked by uid 99); 12 Mar 2007 16:31:46 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Mar 2007 09:31:46 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [208.30.140.160] (HELO moroha.quovadx.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Mar 2007 09:31:35 -0700 Received: from qxvcexch01.ad.quovadx.com ([192.168.170.59]) by moroha.quovadx.com (8.13.6/8.13.6) with ESMTP id l2CGVEtZ024183 for ; Mon, 12 Mar 2007 16:31:14 GMT Received: from [10.70.3.113] ([10.70.3.113]) by qxvcexch01.ad.quovadx.com with Microsoft SMTPSVC(6.0.3790.1830); Mon, 12 Mar 2007 10:31:03 -0600 Message-ID: <45F580EF.805@roguewave.com> Date: Mon, 12 Mar 2007 09:33:51 -0700 From: Martin Sebor Organization: Rogue Wave Software User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.2) Gecko/20070221 SeaMonkey/1.1.1 MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: [Fwd: Re: svn commit: r511019 - in /incubator/stdcxx/trunk/tests: include/23.list.h src/23.containers.cpp] Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 12 Mar 2007 16:31:03.0993 (UTC) FILETIME=[D3E7C290:01C764C3] X-Virus-Checked: Checked by ClamAV on apache.org Farid, please make sure to correct the static inline issue in this patch before we forget. Thanks Martin -------- Original Message -------- Subject: Re: svn commit: r511019 - in /incubator/stdcxx/trunk/tests: include/23.list.h src/23.containers.cpp Date: Tue, 06 Mar 2007 19:24:16 -0700 From: Martin Sebor Organization: Rogue Wave Software To: stdcxx-dev@incubator.apache.org References: <20070223170412.211291A981A@eris.apache.org> faridz@apache.org wrote: > Author: faridz > Date: Fri Feb 23 09:04:11 2007 > New Revision: 511019 > > URL: http://svn.apache.org/viewvc?view=rev&rev=511019 > Log: > 2007-02-23 Farid Zaripov > > ChangeLog: > * 23.list.h: New file with definitions of helpers used in > clause 23.list tests. > * 23.containers.cpp: #included 23.list.h; removed definition > of the temporary struct ListIds; _rw_list_sigcat filled by code. > > Added: > incubator/stdcxx/trunk/tests/include/23.list.h (with props) > Modified: > incubator/stdcxx/trunk/tests/src/23.containers.cpp > > Added: incubator/stdcxx/trunk/tests/include/23.list.h > URL: http://svn.apache.org/viewvc/incubator/stdcxx/trunk/tests/include/23.list.h?view=auto&rev=511019 > ============================================================================== > --- incubator/stdcxx/trunk/tests/include/23.list.h (added) > +++ incubator/stdcxx/trunk/tests/include/23.list.h Fri Feb 23 09:04:11 2007 > @@ -0,0 +1,285 @@ [...] > +template > +static inline bool ^^^^^^ I suspect the static linkage is going to cause the same problem as in 23.limits.traps. We're already getting warnings from Sun C++: CC -c -D_RWSTD_USE_CONFIG -I$(TOPDIR)/include -I$(BUILDDIR)/include -I$(TOPDIR)/../rwtest -I$(TOPDIR)/tests/include -library=%none -O -xarch=v9 +w $(TOPDIR)/tests/src/23.containers.cpp "$(TOPDIR)/tests/include/23.list.h", line 228: Warning (Anachronism): "static" is not allowed and is being ignored. [...] > +template > +struct ListState > +{ > + typedef typename List::const_iterator ListCIter; > + typedef typename List::const_pointer ListCPtr; > + > + _RWSTD_SIZE_T size_; > + ListCIter* iters_; > + ListCPtr* ptrs_; > + > + ListState (List const & lst) : size_ (lst.size ()), iters_ (0), ptrs_ (0) > + { The formatting convention is not to drop the curly brace in definitions of member functions in the body of the "parent" class. > + iters_ = new ListCIter [size_]; > + ptrs_ = new ListCPtr [size_]; > + > + _RWSTD_SIZE_T index = 0; > + for (ListCIter it = lst.begin (), end = lst.end (); > + it != end; ++it, ++index) { > + > + iters_ [index] = it; > + ptrs_ [index] = &*it; > + } > + } > + > + ~ListState () > + { Same here. > + delete [] iters_; > + delete [] ptrs_; > + } > + > + // invokes rw_assert() to verify that two states are the same > + void assert_equal (const ListState& state, int line, > + int case_line, const char* when) const > + { And here. > + const int equal = size_ == state.size_ It probably doesn't matter (I don't think any compiler issues a warning) but I suppose the type of the constant should be int. Martin