Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 94880 invoked from network); 20 Feb 2007 19:11:57 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 20 Feb 2007 19:11:57 -0000 Received: (qmail 62006 invoked by uid 500); 20 Feb 2007 19:12:05 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 61945 invoked by uid 500); 20 Feb 2007 19:12:05 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 61934 invoked by uid 99); 20 Feb 2007 19:12:05 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Feb 2007 11:12:05 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [208.30.140.160] (HELO moroha.quovadx.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Feb 2007 11:11:54 -0800 Received: from qxvcexch01.ad.quovadx.com (qxvcexch01.ad.quovadx.com [192.168.170.59]) by moroha.quovadx.com (8.13.6/8.13.6) with ESMTP id l1KJBE58016667 for ; Tue, 20 Feb 2007 19:11:15 GMT Received: from [10.70.3.113] ([10.70.3.113]) by qxvcexch01.ad.quovadx.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 20 Feb 2007 12:11:16 -0700 Message-ID: <45DB478F.20408@roguewave.com> Date: Tue, 20 Feb 2007 12:10:07 -0700 From: Martin Sebor Organization: Rogue Wave Software User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.2pre) Gecko/20070111 SeaMonkey/1.1 MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: [PATCH] introducing rw_value.h and value.cpp References: <45DB2BE7.1060504@kyiv.vdiweb.com> In-Reply-To: <45DB2BE7.1060504@kyiv.vdiweb.com> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 20 Feb 2007 19:11:16.0127 (UTC) FILETIME=[E4EC02F0:01C75522] X-Virus-Checked: Checked by ClamAV on apache.org Farid Zaripov wrote: > Hi All. > > Attached is a first small patch from the splitted big patch. > > ChangeLog: > * alg_test.h (struct X, struct UnaryPredicate, > struct BinaryPredicate): Declarations moved from here ... > * rw_value.h: ... to here (new header file). > * alg_test.cpp: Updated copyright notice; > (struct X, struct UnaryPredicate, struct BinaryPredicate, > _rw_fmtxarrayv, _rw_fmtxarray): Definitions moved from here ... > * value.cpp: ... to here (new source file). This looks good to me. Feel free to commit a change renaming struct X and all the tests that use it in a subsequent change. Or create a Jira task as a reminder for us to do it later. Thanks Martin