stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Farid Zaripov" <Far...@kyiv.vdiweb.com>
Subject RE: [PATCH] Fix of STDCXX-127
Date Thu, 15 Feb 2007 14:43:35 GMT
> -----Original Message-----
> From: Martin Sebor [mailto:sebor@roguewave.com] 
> Sent: Wednesday, February 14, 2007 8:57 PM
> To: stdcxx-dev@incubator.apache.org
> Subject: Re: [PATCH] Fix of STDCXX-127

> Ft, since you assert that "if one of pointers is so must be 
> the other" it seems to me that the condition in the if above 
> could be simplified for efficiency to just (and the same below):
> 
>    if (pointer () == _C_beg._C_cur) {
>        _RWSTD_ASSERT (pointer () == _C_end._C_cur);
>        ...
>    }
>    else {
>        _RWSTD_ASSERT (pointer () != _C_end._C_cur);
>    }
> 

  Commited thus: http://svn.apache.org/viewvc?view=rev&rev=507940

> Second, since swap is not a trivial function anymore after 
> this change (it could have been considered non-trivial even 
> before it) we should outline it and move its definition to deque.cc.

  Commited thus: http://svn.apache.org/viewvc?view=rev&rev=507942

> Do you agree?

  Completely.

Farid.

Mime
View raw message