stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Farid Zaripov <far...@kyiv.vdiweb.com>
Subject Re: [PATCH] alg_test.h
Date Wed, 21 Feb 2007 05:29:16 GMT
Martin Sebor wrote:
>>   Attached patch is created using the patch utility (ported from unix), 
>> because I can't use TortoiseSVN plugin to make patch between 2 files on 
>> my harddisk.
>
> Hmm. svn diff doesn't work you on Windows? Have you tried Cygwin?

  I'm using the TortoiseSVN shell extension plugin, but not the svn binary utils.
I will try the latest to see how the 'svn diff' can help.

>> 
>>   ChangeLog:
>>   * alg_test.h: ConstFwdIter<T> inherited from FwdIter<const T>.
>>   ConstBidirIter<T> inherited from BidirIter<const T>.
>>   ConstRandomAccessIter<T> inherited from RandomAccessIter<const T>.
>>   (make_iter): type of the last parameter changed to const reference
>
> This intuitively makes sense. I wonder, though, does it fix
> a real problem in the test suite?

  Yes, the test 23.vector.modifiers fails to compile due to ambiguity
between 2 similar overloads of the make_iter() function (because
ConstFwdIter<T> inherited from FwdIter<T> and can be used in call to
make_iter(, , , FwdIter<T>) while ConstFwdIter<T>, inherited from
FwdIter<const T>, cannot).

> If so, it would be nice to
> have a small test case (if it's simple enough) and a Jira
> issue for it.

  New JIRA issue: http://issues.apache.org/jira/browse/STDCXX-341

> Either way, consider the change preapproved.

Farid.



Mime
View raw message