stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: [PATCH] bitset.cc (STDCXX-297)
Date Wed, 18 Oct 2006 16:32:12 GMT
Farid Zaripov wrote:

>  > -----Original Message-----
>  > From: Martin Sebor [mailto:sebor@roguewave.com]
>  > Sent: Wednesday, October 11, 2006 8:10 PM
>  > To: stdcxx-dev@incubator.apache.org
>  > Subject: Re: [PATCH] bitset.cc (STDCXX-297)
>  >
> [...]
>  > We could deal with it by having
>  > two code paths, a faster one for power-of-2 CHAR_BIT values
>  > and a slower one for the rare cases when it isn't (guarded by
>  > suitable #if's).
> 
>   New patch is attached.

Looks good.

We should also add a test for this to our test suite (or enhance
the existing bitset test). Alternatively, we might want to start
adding these test cases to our regression test suite.

Martin


Mime
View raw message