stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: [PATCH] std::swap (std::container&, std::container&) in MSVC 7.0
Date Thu, 28 Sep 2006 15:39:01 GMT
Farid Zaripov wrote:
>  > -----Original Message-----
>  > From: Martin Sebor [mailto:sebor@roguewave.com]
>  > Sent: Thursday, September 28, 2006 5:29 PM
>  > To: stdcxx-dev@incubator.apache.org
>  > Subject: Re: [PATCH] std::swap (std::container&,
>  > std::container&) in MSVC 7.0
>  >
>  > Okay, so it doesn't sound like we need it. We can add it
>  > if/when we find a compiler that doesn't support inline
>  > friends and that also doesn't do partial ordering of function
>  > templates.
> 
>   The updated (with updating the licensing header) patch is attached:

This looks good. Could you just make one tiny formatting change
before committing it? The opening curly brace should be on the
same line as the function declaration in functions defined in
the body of a class. I.e., like this:

     class deque {
         friend void swap (deque &__lhs, deque &__rhs) {
             __lhs.swap (__rhs);
         }
     };

We're not completely consistent in this but that's where we're
headed.

Thanks
Martin

Mime
View raw message