stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: [PATCH] etc/config/src
Date Mon, 25 Sep 2006 20:39:08 GMT
Farid Zaripov wrote:
>>-----Original Message-----
>>From: Martin Sebor [mailto:sebor@roguewave.com] 
>>Sent: Monday, September 25, 2006 7:38 PM
>>To: stdcxx-dev@incubator.apache.org
>>Subject: Re: [PATCH] etc/config/src
>>
> 
> 
>>I was suggesting that the TLS.cpp config test be changed to print
>>out the #definition of the _RWSTD_THREAD_MACRO that's appropriate
>>for the compiler. That would let us keep all the logic in the test
>>and simplify the preprocessor conditionals in the rw/_config.h and
>>rw/_defs.h headers.
> 
>   Agreed.
> 
>   Commited here: http://svn.apache.org/viewvc?view=rev&rev=449771

Okay, thanks. A couple of comments on changes that were not in the
original patch (it's a good practice to post a new patch with any
changes to the original :)

TLS.cpp: The macro _RWSTD_THREAD_STR is #defined but doesn't appear
to be used. Compiling the file with gcc gives the following error:
$ gcc TLS.cpp
TLS.cpp:28:1: error: pasting "(" and "_RWSTD_THREAD" does not give
a valid preprocessing token

I corrected this and committed the result here:
http://svn.apache.org/viewvc?view=rev&rev=449799

wthread.h: the pthread-sompatibility symbols should be declared
extern "C" (extern "C" and extern "C++" functions and pointers
to functions are incompatible with one another).

I corrected this. I also made another change to the header that
I think you'll like -- I allowed it to be #included regardless
of the platform by handling _WIN32 in the header rather than in
the #including .cpp file. I renamed the hader from wthread.h to
the more general thread.h and simplified the THREAD_SAFE_*.cpp
files. Here's the change:
http://svn.apache.org/viewvc?view=rev&rev=449809

Martin

Mime
View raw message