stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Sebor <se...@roguewave.com>
Subject Re: [PATCH] Scripts, generating solution and projects for MSVC/ICC
Date Mon, 18 Sep 2006 00:48:35 GMT
Farid Zaripov wrote:
>   I have been updated the scripts.
> 
>   The diff file: http://people.apache.org/~faridz/ver2/scripts.diff
> 
>   The copy of etc/config/windows from my working copy is here:
> http://people.apache.org/~faridz/ver2/windows/

I haven't had time to play with it but just quickly going through
the code it seems pretty clean :) but only sparsely documented so
it's hard for me to figure out what the purpose of each variable
or function is. It would be helpful to document them.

For example, in configure.wsf, the non-trivial function configure()
seems pretty important but there's no comment above it explaining
what it does. OTOH, the next function down, removeFile(), looks
trivial but it does have a comment describing its effects.

I would like to see a comment at the top of each function with
a description of each of its arguments as well as a description
of the function's effects. More inline documentation would also
be welcome.

Btw., from the .config files it looks like we're using the link
command directly to link. Shouldn't we be using the compiler to
do this instead (that's what MSDN recommends, anyway).

> 
>   Brief changelog:
> 1) solution file generated without using automation objects (because of
>     the MSVC Express doesn't registers this objects);
> 2) rwtest library will be built as dynamic library in "... Dll" solution
> configurations
> 
>   I have tried to build stdcxx on MSVC 7.0 and got some errors so I can
> say that we don't support MSVC 7.0 at the moment.

Let's fix these before committing the changes.

> 
>   Some tests failed to link in "... Dll" configurations because of not
> all used from rwtest symbols are exported.
> 
>   I'll show the details later.

Okay, that would be good. It would be good to fix these before
committing these changes, as well, so the commit don't introduce
any regressions.

Oh, one last thing. Could you please add the usual ASF license
notices (without the Rogue Wave copyright, obviously :) to all
the files?

Thanks
Martin

Mime
View raw message