From stdcxx-dev-return-1951-apmail-incubator-stdcxx-dev-archive=incubator.apache.org@incubator.apache.org Tue Aug 15 21:03:02 2006 Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 22807 invoked from network); 15 Aug 2006 21:03:02 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 15 Aug 2006 21:03:02 -0000 Received: (qmail 5781 invoked by uid 500); 15 Aug 2006 21:03:02 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 5764 invoked by uid 500); 15 Aug 2006 21:03:02 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 5753 invoked by uid 99); 15 Aug 2006 21:03:02 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Aug 2006 14:03:02 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [208.30.140.160] (HELO moroha.quovadx.com) (208.30.140.160) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Aug 2006 14:02:59 -0700 Received: from [10.70.3.48] ([10.70.3.48]) by moroha.quovadx.com (8.13.6/8.13.4) with ESMTP id k7FL2akG031264 for ; Tue, 15 Aug 2006 21:02:36 GMT Message-ID: <44E2366C.3060206@roguewave.com> Date: Tue, 15 Aug 2006 15:02:36 -0600 From: Andrew Black User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.5) Gecko/20060720 SeaMonkey/1.0.3 MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: [patch] resolve segv in locale/localedef Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Greetings all. Below is a 2 line patch to the locale and localedef utilities that resolves a segfault encountered during automated testing (and adds a missing newline). This problem generally shows up during stage 2 of the run_locale_utils.sh script. --Andrew Black Log: * scanner.cpp (Scanner::convert_escape): Correct order of arguments to an issue_diag call, add missing newline. Index: scanner.cpp =================================================================== --- scanner.cpp (revision 431602) +++ scanner.cpp (working copy) @@ -734,8 +734,8 @@ if (val < 0 || val > long (UCHAR_MAX)) issue_diag (E_INVAL, true, 0, - "%s value in the range [0, %lu) expected: %s", - basename, esc, long (UCHAR_MAX)); + "%s value in the range [0, %lu) expected: %s\n", + basename, long (UCHAR_MAX), esc); typedef unsigned char UChar;