stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Farid Zaripov" <>
Subject RE: testsuite process helpers [PATCH]
Date Thu, 03 Aug 2006 14:19:04 GMT
> -----Original Message-----
> From: Martin Sebor [] 
> Sent: Wednesday, August 02, 2006 8:30 PM
> To:
> Subject: Re: testsuite process helpers [PATCH]
> >     * rw_process.h (rw_pid_t): The type long changed to intptr_t
> >     (on Windows) and pid_t (on other platforms).
> I would like to hide the actual type and avoid #including 
> system (including the C library) headers in test suite 
> headers whenever possible. In this case, will _RWSTD_SIZE_T 
> do for rw_pid_t?

  rw_pid_t should be signed, and should be 64 bit on 64-bit platforms.
I see that _RWSTD_SSIZE_T can be used.

> Is this enough? Don't we want to suppress the output of rw_note() (and
others as well)? 
> If so, I think a more robust solution might be for driver.cpp to
provide and handle a 
> variable controlling whether to issue or suppress a 
> diagnostic (and which). Something like int rw_diag_mask each 
> of whose bits would disable the corresponding diagnostic.

  I found that variable is already exist (_rw_diag_mask in opt_trace.h).
We can declare it
in driver.h (with removing the leading underscore of course) but it is
still not exactly what
is needed. When any diagnostic are masked it still counted and is
present in totals. But
in the case of 0.process.cpp test we need temporary disable the all
diagnostic messages
with disabling the counting ot that messages.

  Another point: if we want to disable some type of diagnostic using
rw_diag_mask it is
needed to move the enum diag_t from opt_diags.h to driver.h too. 

  I propose add two functions enable_diag() / disable_diag(), or just
enable_diag(bool enable)
to the driver (and use any unused bit in _rw_diag_mask). We can publish
the _rw_diag_mask
along with enum diag_t later when it's will be required.


View raw message